-
-
Notifications
You must be signed in to change notification settings - Fork 82
docs: Add 'What is SDUI?' documentation page #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new Server-Driven UI (SDUI) documentation page ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (5)
docs/docs.json (1)
29-34: Consider moving “sdui” before “quickstart” for an intro-first flow.Readers typically want the concept before the tutorial. Suggest order: introduction, sdui, quickstart, cli, project_structure.
Apply within the pages array:
- "pages": [ - "introduction", - "quickstart", - "sdui", - "cli", - "project_structure" - ] + "pages": [ + "introduction", + "sdui", + "quickstart", + "cli", + "project_structure" + ]docs/sdui.mdx (4)
23-34: Normalize heading levels: make Pros/Cons H2 to match peer sections.Sibling sections (“How is…”, “Good Use Cases”, “Next steps”) are H2. Align for consistent TOC.
-### Pros: +## Pros ... -### Cons: +## Cons
25-26: Style consistency: “App Store” vs “app store(s)”.Earlier you use “app stores” (lowercase). Keep consistent here.
-- Rapid deployment without App Store delays +- Rapid deployment without app store delays
46-54: Soften/qualify company list or add references.Claims may drift; prefer “Examples include” or add citations.
-## Companies actively building with SDUI +## Companies using SDUI (examples) ... -- **Netflix** +- **Netflix** (example)Alternatively, add a short “References” section with links to public posts.
Would you like me to assemble a short references list?
8-14: Minor punctuation/flow nits (optional).Replace semicolon with colon for list intro; consider merging the two sentences for brevity.
-In a traditional Client-Driven UI model, the app’s UI is tightly coupled to its codebase. The client handles everything; layouts, business logic, and rendering. +In a traditional client‑driven UI model, the app’s UI is tightly coupled to its codebase. The client handles everything: layouts, business logic, and rendering.(Based on LanguageTool hint.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/assets/sdui.pngis excluded by!**/*.png
📒 Files selected for processing (2)
docs/docs.json(1 hunks)docs/sdui.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/sdui.mdx
[style] ~44-~44: Consider using a synonym to be more concise.
Context: ...iven UI has gained significant traction in recent years. Both startups and large enterprises no...
(IN_RECENT_STYLE)
🔇 Additional comments (1)
docs/sdui.mdx (1)
57-60: Confirm or create Widgets landing page
Nodocs/widgets.mdxordocs/widgets/index.mdxwas found. Please run:fd -HI -a -g 'widgets/*.mdx' docs | head -n 5to verify there are widget pages. If none exist, add
docs/widgets/index.mdxor update the link to point to a specific widget file.
divyanshub024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/sdui.mdx (1)
22-22: Add alt text and verify asset path.The
<img>tag is missing alt text, which breaks accessibility. Additionally, the asset path should be verified and likely use a relative path instead of absolute.Apply this diff to add alt text and adjust the path:
-<img src="/assets/sdui.png"/> +<img src="./assets/sdui.png" alt="SDUI workflow diagram showing server sending JSON schema to mobile app for dynamic rendering" />Please verify the correct path for the image asset relative to the docs build output directory (e.g.,
./assets/,../assets/, or/static/assets/).
🧹 Nitpick comments (1)
docs/sdui.mdx (1)
45-45: Tighten verbose phrasing.The phrase "gained significant traction in recent years" is slightly redundant. Consider a more direct statement.
-Server-Driven UI has gained significant traction in recent years. Both startups and large enterprises now use it extensively. +Server-Driven UI is now widely adopted by both startups and large enterprises.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/sdui.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/sdui.mdx
[style] ~45-~45: Consider using a synonym to be more concise.
Context: ...iven UI has gained significant traction in recent years. Both startups and large enterprises no...
(IN_RECENT_STYLE)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Add 'What is SDUI?' documentation page
Type of Change
Summary by CodeRabbit