Added a reader.Close() and reader=null to QueryInternal. #55

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

haeal commented Oct 10, 2012

This stops spurious log messages in Postgres, and stops intermittent aborted queries from what looks to be a race condition. This has only been tested in Postgres.

@haeal haeal Added a reader.Close() and reader=null to QueryInternal.
This stops spurious log messages in Postgres, and stops intermittent
aborted queries from what looks to be a race condition.  This has
only been tested in Postgres.
5e47be6
Contributor

mgravell commented Oct 10, 2012

I couldn't merge automatically, but has been applied, with some tweaks:

  • I'm calling Dispose() instead of Close(), as we should still formally dispose the reader, and Dispose() typically calls Close()
  • added to QueryMultiple (via GridReader)
  • (also includes slightly related tweak re cleanly shutting GridReader)

Can you check whether it works with the as-pushed code?

haeal commented Oct 10, 2012

Seems to work fine against my tests. No log messages, so it should be working right.

haeal closed this Oct 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment