Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break because the schema changes; if it changes in a breaking way, we'll know anyway #76

Merged
merged 1 commit into from Apr 19, 2016

Conversation

@tms
Copy link
Contributor

tms commented Apr 19, 2016

Per "The 'SecurityPolicyApplied' attribute is not declared", almost every time SQL Server gets updated there are attributes added to the execution plan schema, which breaks the schema validation done while processing the execution plan if no one remembers to update the XSD in DataExplorer.

But there's really no reason to do a schema validation in the first place, since we can generally trust that SQL Server will return a conformant execution plan XML, and if there are breaking changes we'll know because the execution plans will stop displaying correctly—more informative and less likely than the current behaviour of breaking because of stuff we don't even care about.

@NickCraver NickCraver merged commit 0a760bb into StackExchange:master Apr 19, 2016
@NickCraver

This comment has been minimized.

Copy link
Member

NickCraver commented Apr 19, 2016

Agreed, good fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.