NEW PROVIDER: Sakura Cloud (SAKURACLOUD)#3086
NEW PROVIDER: Sakura Cloud (SAKURACLOUD)#3086tlimoncelli merged 4 commits intoStackExchange:mainfrom
Conversation
cafferata
left a comment
cafferata
left a comment
There was a problem hiding this comment.
@tlimoncelli, could you also do a review?
| {% endcode %} | ||
|
|
||
| The default TTL of Sakura Cloud is 3600, so it's recommended to set | ||
| `DefaultTTL(3600)`. |
There was a problem hiding this comment.
Question: What happens within Sakura Cloud/DNSControl if you do not include this defaultTTL?
There was a problem hiding this comment.
The DefaultTTL value set by the user is simply set to Sakura Cloud.
I realise that DefaultTTL(3600) is a meaningless setting for a user, so I am removing this description.
SAKURACLOUD: Deletion of description about default TTL (3600)
There was a problem hiding this comment.
Thanks for the explanation and the code adjustment.
| // - exampleN, where N is a numerical character | ||
| func rejectifLabelHasExample(rc *models.RecordConfig) error { | ||
| return hasLabelExample(rc.GetLabel()) | ||
| } |
There was a problem hiding this comment.
Compliment: I wanted to compliment you on the extensive audit records! 👏🏻
There was a problem hiding this comment.
Thanks for your compliment.
| "TYPE": "SAKURACLOUD", | ||
| "access_token": "$SAKURACLOUD_ACCESS_TOKEN", | ||
| "access_token_secret": "$SAKURACLOUD_ACCESS_TOKEN_SECRET", | ||
| "domain": "$SAKURACLOUD_DOMAIN" |
There was a problem hiding this comment.
Question: Have you sent @tlimoncelli credentials for the automated integration tests? Is that possible for Sakura Cloud? 🙏🏻
There was a problem hiding this comment.
I have not done.
I tested my own domain name on my personal account on Sakura cloud.
I will therefore consider if it is possible.
There was a problem hiding this comment.
I sent credentials for Sakura Cloud via stack overflow.
| Initializer: newSakuracloudDsp, | ||
| RecordAuditor: AuditRecords, | ||
| } | ||
| providers.RegisterDomainServiceProviderType("SAKURACLOUD", fns, features) |
There was a problem hiding this comment.
Change: The function RegisterMaintainer() needs to be included so that the OWNERS is generated successfully.
const providerMaintainer = "@ttkzw"
providers.RegisterMaintainer(providerName, providerMaintainer)See also the other examples: https://github.com/search?q=repo%3AStackExchange%2Fdnscontrol+path%3A%2F%5Eproviders%5C%2F%2F+const+providerMaintainer&type=code
There was a problem hiding this comment.
Added RegisterMaintainer().
|
Congrats! This PR is ready to merge! I received your access token for automated testing. Please file a separate PR as described in https://docs.dnscontrol.org/developer-info/byo-secrets to add the provider to the automated testing. |
3 participants
This PR adds support for Sakura Cloud, https://cloud.sakura.ad.jp/products/dns/ .
Passes all integration tests except for features not supported by the provider and tested in my own domain.