Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process workflow output in other completed states #101

Merged
merged 1 commit into from Nov 9, 2018
Merged

Conversation

@m4dcoder
Copy link
Collaborator

@m4dcoder m4dcoder commented Nov 8, 2018

Previously, workflow output is processed only when workflow succeeds. This patch enables workflow output to be processed when workflow completes, regardless of success or failure. If there is a evaluation error, the line item in the output will be skipped and evaluation error recorded. When there is an output evaluation error, the workflow will be marked as failed.

Previously, workflow output is processed only when workflow succeeds. This patch enables workflow output to be processed when workflow completes, regardless of success or failure. If there is a evaluation error, the line item in the output will be skipped and evaluation error recorded. When there is an output evaluation error, the workflow will be marked as failed.
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 8, 2018

Codecov Report

Merging #101 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   94.22%   94.22%   +<.01%     
==========================================
  Files          38       38              
  Lines        2371     2372       +1     
  Branches      468      468              
==========================================
+ Hits         2234     2235       +1     
  Misses         79       79              
  Partials       58       58
Impacted Files Coverage Δ
orquesta/conducting.py 91.87% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddb8aa...deec020. Read the comment docs.

@blag
blag approved these changes Nov 9, 2018
@m4dcoder m4dcoder merged commit b262dd2 into master Nov 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@m4dcoder m4dcoder deleted the workflow-output branch Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants