New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert strings in context to unicode #98

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@m4dcoder
Copy link
Collaborator

m4dcoder commented Nov 2, 2018

Make strings in context unicode by default. This will avoid problems with manipulating strings of mix ascii and unicode type in expressions.

Convert strings in context to unicode
Make strings in context unicode by default. This will avoid problems with manipulating strings of mix ascii and unicode type in expressions.

@m4dcoder m4dcoder requested a review from bigmstone Nov 2, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #98 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   94.11%   94.17%   +0.06%     
==========================================
  Files          38       38              
  Lines        2309     2334      +25     
  Branches      453      459       +6     
==========================================
+ Hits         2173     2198      +25     
  Misses         79       79              
  Partials       57       57
Impacted Files Coverage Δ
orquesta/expressions/yql.py 90% <100%> (+0.75%) ⬆️
orquesta/utils/strings.py 100% <100%> (ø) ⬆️
orquesta/expressions/jinja.py 92.48% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad06833...363ab08. Read the comment docs.

@bigmstone
Copy link
Contributor

bigmstone left a comment

LGTM

@m4dcoder m4dcoder merged commit 73e06ae into master Nov 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m4dcoder m4dcoder deleted the fix-unicode-context branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment