Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert part of #4609, fixes #4650 #4656
Conversation
LindsayHill
approved these changes
May 2, 2019
|
Assuming your CI failures are due to other changes you're making to the test infrastructure, this is OK. |
This comment has been minimized.
This comment has been minimized.
|
Please also add a Changelog entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
blag commentedMay 2, 2019
One line fix for
source_channel.In the future, it would be nice to simply use one
source_contextvariable to store all of the information from the chat provider, but this fixes previous behavior.Reverts part of #4609.
Fixes #4650.