Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Disabled removing lock for orphanded #4886
This stopped my execution queue item from being requested more than once for long running requests. Is there a config setting for the timing of this? I am not sure if this is needed since there is retry code in the code base.
@blag mentioned we need a unit test for this PR. before I spend a bunch of time on that can someone please at least bless the approach here.
m4dcoder left a comment
The scheduler's garbage collection actively looks for action execution that is locked for long time and hasn't been released. This may be caused by a scheduler being terminated abnormally before releasing locks. The time before a lock is manually released by GC is set at the constant EXECUTION_SCHEDUELING_TIMEOUT_THRESHOLD_MS. This is currently not configurable. Since this issue is specific to the end user (large input which causes delay in scheduling), the solution should be to make EXECUTION_SCHEDUELING_TIMEOUT_THRESHOLD_MS configurable and then the end user adjust the value according to needs.
You don't have to close this a create a new PR, you can just:
# Fetch changes from all branches from GitHub git fetch --all # Checkout the master branch git checkout master # Pull in all changes to your local master branch git pull # Switch back to your patch-5 branch git checkout patch-5 # Rebase back on top of the master branch git rebase master
And then you can just continue development in this branch as normal.