Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document number of workers per service #960

Merged
merged 7 commits into from Feb 7, 2020
Merged

document number of workers per service #960

merged 7 commits into from Feb 7, 2020

Conversation

@punkrokk
Copy link
Contributor

punkrokk commented Feb 5, 2020

Add note to HA docs to document how to increase the number of workers in the Action Runner service.

Credit to @nmaludy: https://github.com/StackStorm/puppet-st2/blob/master/templates/etc/sysconfig/st2actionrunner.erb

@punkrokk punkrokk requested review from armab and nmaludy Feb 5, 2020
docs/source/reference/ha.rst Outdated Show resolved Hide resolved
punkrokk added 5 commits Feb 6, 2020
This reverts commit 57d207f
@nmaludy
nmaludy approved these changes Feb 7, 2020
Copy link
Contributor

nmaludy left a comment

LGTM!

@armab

This comment has been minimized.

Copy link
Member

armab commented Feb 7, 2020

The text/description looks good 👍
I'm wondering if there is a better place for st2actionrunner configuration, outside of HA deployment? Setting number of workers is not just HA-specific, but valid for any st2 configuration.

@punkrokk @nmaludy What do you think about including this info in https://docs.stackstorm.com/install/config/config.html page instead? And we can-cross link from HA doc to the main configuration doc.

@armab armab added the enhancement label Feb 7, 2020
@nmaludy

This comment has been minimized.

Copy link
Contributor

nmaludy commented Feb 7, 2020

@armab I thought the same thing but couldn't find the right place for it. I like your suggested location. We could then reference this from the HA docs?

@punkrokk

This comment has been minimized.

Copy link
Contributor Author

punkrokk commented Feb 7, 2020

@nmaludy @armab I like the suggestion. I just pushed it. Just need to confirm the links work properly.

@armab
armab approved these changes Feb 7, 2020
Copy link
Member

armab left a comment

Looks really good 👍

Thanks for initiative documenting it, the right way.

@punkrokk

This comment has been minimized.

Copy link
Contributor Author

punkrokk commented Feb 7, 2020

any time!

@punkrokk punkrokk merged commit 6b41de5 into master Feb 7, 2020
2 checks passed
2 checks passed
ci/circleci: ewcdocs Your tests passed on CircleCI!
Details
ci/circleci: st2docs Your tests passed on CircleCI!
Details
@punkrokk punkrokk deleted the workers branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.