-
-
Notifications
You must be signed in to change notification settings - Fork 117
Add mongo auth #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mongo auth #63
Conversation
|
@Lomonosow Thank you for your contribution. I'll be reviewing it shortly. |
|
I found some mistake in configuration, mongo want key at least 6 symbols length. I have fix it in my commit. |
|
@warrenvw Can you please drive this review, think about corner cases and check the PR? From my point of view it would be nice to add a condition and set mongo username/password in |
warrenvw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Lomonosow. I manually tested this PR against our EKS cluster, and can only see a few things I'd do differently.
|
I'd appreciate if you could update the Changelog and bump the version in Please note that I have not been able to successfully transition mongodb from auth disabled to auth enabled. Have you tried this? I'm attempting this particular scenario because auth is likely disabled on most installations... and now by default it will be enabled. For example, in the |
I have reproduce it when I`d change mongodb admin password and tried to upgrade helm release. Mongodb chart does not recreate user if directory for db already exists (in mongodb persistent storage enabled by default and if you delete release by helm, persistent storage will not be deleted). |
#13 Is work for me, but use mongo admin user. I`d tried to find another way but unsuccessfully)