test: export boundary tests for @stackbilt/ci, classify, and validate#174
Merged
Conversation
…date Fixes #167. Adds 30 new tests across three packages that had no or partial export coverage: - @stackbilt/ci: first test file — verifies all 5 exports are functions, exercises annotateDriftViolations (BLOCKER/LOW/empty), annotateValidationStatus (FAIL/WARN/PASS), and formatPRComment (status, violations, suggestions, score) - @stackbilt/classify: adds formatChangeClassification boundary test (export existence + markdown output shape); keeps existing heuristicClassify / determineRecommendation coverage - @stackbilt/validate: new exports.test.ts — boundary check for all 4 top-level exports (validateCitations, extractCitations, enrichCitations, classifyMessage) plus behavioral tests for citation extraction, validation result shape, and message intent classification @stackbilt/surface already has comprehensive route/schema coverage in surface.test.ts; no changes needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Review finding (blocking): The new Current failures from the PR run:
Affected lines in this PR:
Please update fixtures to the actual |
antiPattern replaces category (not in type); LOW replaced with MINOR (valid severities: BLOCKER | CRITICAL | MAJOR | MINOR). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Fixed in 7639b63. Replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
annotateDriftViolations/annotateValidationStatus/formatPRCommentexercised with realistic inputsformatChangeClassificationboundary test (was exported but untested); existingheuristicClassify/determineRecommendationcoverage unchangedexports.test.ts— boundary check for all 4 top-level exports plus behavioral tests for citation extraction, validation result shape, and message intent classificationsurface.test.tsalready imports all public exports; no changes neededCloses #167.
Test plan
pnpm vitest run) — up from 490 (+30 new)🤖 Generated with Claude Code