Skip to content

Conversation

@StevenYCChou
Copy link
Contributor

@StevenYCChou StevenYCChou commented Feb 28, 2019

Ran e2e test when released 0.4.0, which specified Prometheus 2.6.0 and succeeded. Therefore, add this section into the compatibility graph.

@StevenYCChou StevenYCChou requested a review from jkohen February 28, 2019 21:59
README.md Outdated
|-----------------|---------------------|---------------------|---------------------|
| **0.2.x** || - | - |
| **0.3.x** || - ||
| **0.4.x** | - | - ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 2.4.3 not work, or you haven't tested it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test against 2.4.3 yet, so I leave it empty there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-" means "no" right now. Can you make it something like ? and then add below "?: not verified yet"? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Please take a look and let me know what do you think, thanks.

Copy link
Contributor

@jkohen jkohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jkohen jkohen merged commit 2708583 into master Mar 4, 2019
@jkohen jkohen deleted the add-section-in-compatibility-diagram branch March 4, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants