Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer function returns false when wrapped in a require statement #5

Closed
wilhempujar opened this issue Jul 3, 2019 · 0 comments
Assignees
Labels
Bug

Comments

@wilhempujar
Copy link
Contributor

@wilhempujar wilhempujar commented Jul 3, 2019

BUG

While having other smart contracts communicate with the DSLA token contract, we noticed they might run into issues when wrapping the DSLA token contract transfer function in a require statement like the following:

function transferTokens(_to)
  require(dsla.transfer(_to, amount));
end

FIX

After investigation, it appears that the transfer function of the DSLA token contract always returns false because it presently lacks a return statement, an issue simular to the one extensively described in this article.

To ensure full compatibility of the DSLA token contract with other smart contracts, we will apply a patch to the ropsten and mainnet contracts accordingly, using ZeppellinOS patching capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.