Fix/refactor_fa2_compat#34
Merged
Merged
Conversation
Signed-off-by: Roy <hi@royscheeren.com>
Signed-off-by: Roy Scheeren <hi@royscheeren.com>
Contributor
|
Can I get the Link to the deployed contract of ghostnet with the tested entry points into the readme of the package/contracts, please? |
Signed-off-by: Roy Scheeren <hi@royscheeren.com>
Signed-off-by: Roy Scheeren <hi@royscheeren.com>
Signed-off-by: Roy Scheeren <hi@royscheeren.com>
Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
jdsika
approved these changes
Jul 3, 2023
royscheeren
added a commit
that referenced
this pull request
Jul 3, 2023
* Smart contract (#28) * fix(all): npm publish command Signed-off-by: Roy <hi@royscheeren.com> * wIP * feat: WIP Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(smart-contracts): v1 Signed-off-by: Roy Scheeren <hi@royscheeren.com> * chore: nx migration Signed-off-by: Roy Scheeren <hi@royscheeren.com> * chore: fix package-lock Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(smart-contracts): update tests Signed-off-by: Roy Scheeren <hi@royscheeren.com> * chore: update workflow Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat: add readme Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix: formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> * Update README.md (#29) Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital> * Feat/refactor replace axios with fetch (#30) * fix(all): npm publish command Signed-off-by: Roy <hi@royscheeren.com> * refactor: replace axios with native fetch * refactor(acq): pass single object as argument to queryAccessControl function Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(siwt.xyz): update try page with updated argument Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(discord): update queryAccessControl function with updated argument Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(acq): fix Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(acq): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(siwt.xyz): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> * refactor(sdk): replace axios with fetch Signed-off-by: Roy Scheeren <hi@royscheeren.com> * refactor(discord): replace axios with fetch Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(discord): port env var Signed-off-by: Roy Scheeren <hi@royscheeren.com> * test(sdk): update tests Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(sdk): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> * Feat/add missing licenses (#31) * fix(all): npm publish command Signed-off-by: Roy <hi@royscheeren.com> * refactor: replace axios with native fetch * refactor(acq): pass single object as argument to queryAccessControl function Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(siwt.xyz): update try page with updated argument Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(discord): update queryAccessControl function with updated argument Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(acq): fix Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(acq): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> * style(siwt.xyz): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> * refactor(sdk): replace axios with fetch Signed-off-by: Roy Scheeren <hi@royscheeren.com> * refactor(discord): replace axios with fetch Signed-off-by: Roy Scheeren <hi@royscheeren.com> * chore: add missing licenses Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(discord): env port Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(siwt.xyz): formatting Signed-off-by: Roy Scheeren <hi@royscheeren.com> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> Co-authored-by: Roy <hi@royscheeren.com> * Fix/refactor_fa2_compat (#34) * fix(all): npm publish command Signed-off-by: Roy <hi@royscheeren.com> * refactor(smart-contracts): fix fa2 compatability Signed-off-by: Roy Scheeren <hi@royscheeren.com> * feat(smart-contracts): add missing licenses Signed-off-by: Roy Scheeren <hi@royscheeren.com> * fix(smart-contracts): remove unused file Signed-off-by: Roy Scheeren <hi@royscheeren.com> * Update contract address in README.md Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital> Co-authored-by: Carlo van Driesten <carlo.van-driesten@vdl.digital> * Release/v0.0.4 (#36) * fix(all): npm publish command Signed-off-by: Roy <hi@royscheeren.com> * release: v 0.0.4 Signed-off-by: Roy Scheeren <hi@royscheeren.com> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> --------- Signed-off-by: Roy <hi@royscheeren.com> Signed-off-by: Roy Scheeren <hi@royscheeren.com> Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital> Co-authored-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix FA2 Compatibility
Problem
The GitLab repository was archived recently and provided to us by Trillitec as the jsligo FA2 example. The recent developments have been moved to GitHub. We have asked ligo to mention the move of the repo in GitLab to avoid the same problem for others.