-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Homepage demo section #1420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieujacq
had a problem deploying
to
preview
October 17, 2023 15:49
— with
GitHub Actions
Failure
dosubot
bot
added
the
area: frontend
Related to frontend functionality or under the /frontend directory
label
Oct 17, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthieujacq
had a problem deploying
to
preview
October 17, 2023 16:00
— with
GitHub Actions
Failure
matthieujacq
had a problem deploying
to
preview
October 17, 2023 16:32
— with
GitHub Actions
Failure
frontend/app/(home)/components/Sections/DemoSection/DemoSection.tsx
Outdated
Show resolved
Hide resolved
frontend/app/(home)/components/Sections/DemoSection/DemoSection.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
19
const isVideoVisible = | ||
videoRect.top >= 0 && videoRect.bottom <= window.innerHeight; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceeee
frontend/app/(home)/components/Sections/DemoSection/components/VideoPlayer.tsx
Outdated
Show resolved
Hide resolved
mamadoudicko
previously approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice PR @matthieujacq!
matthieujacq
had a problem deploying
to
preview
October 18, 2023 07:54
— with
GitHub Actions
Failure
matthieujacq
had a problem deploying
to
preview
October 18, 2023 08:36
— with
GitHub Actions
Failure
matthieujacq
had a problem deploying
to
preview
October 18, 2023 08:47
— with
GitHub Actions
Failure
mamadoudicko
approved these changes
Oct 18, 2023
VideoPlayer: fix the video playing on screen only reenable eslint Simplify VideoPlayer auto-play/pause code
matthieujacq
force-pushed
the
feat/demo-section
branch
from
October 18, 2023 09:04
bfb19d3
to
ef5eef2
Compare
matthieujacq
had a problem deploying
to
preview
October 18, 2023 09:04
— with
GitHub Actions
Failure
matthieujacq
had a problem deploying
to
preview
October 18, 2023 09:07
— with
GitHub Actions
Failure
mamadoudicko
pushed a commit
that referenced
this pull request
Oct 19, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.94 (2023-10-19) ## What's Changed * feat: Homepage demo section by @matthieujacq in #1420 * feat: add security section by @mamadoudicko in #1423 * feat: HomePage new footer by @matthieujacq in #1425 * feat: add testimonials section by @mamadoudicko in #1427 * refactor(backend): cleaning dead and unused code by @StanGirard in #1432 **Full Changelog**: v0.0.93...v0.0.94 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst
added a commit
to coolCatalyst/quivr
that referenced
this pull request
Jun 1, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.94 (2023-10-19) ## What's Changed * feat: Homepage demo section by @matthieujacq in QuivrHQ/quivr#1420 * feat: add security section by @mamadoudicko in QuivrHQ/quivr#1423 * feat: HomePage new footer by @matthieujacq in QuivrHQ/quivr#1425 * feat: add testimonials section by @mamadoudicko in QuivrHQ/quivr#1427 * refactor(backend): cleaning dead and unused code by @StanGirard in QuivrHQ/quivr#1432 **Full Changelog**: QuivrHQ/quivr@v0.0.93...v0.0.94 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Dream528
added a commit
to Dream528/quivr
that referenced
this pull request
Jul 28, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.94 (2023-10-19) ## What's Changed * feat: Homepage demo section by @matthieujacq in QuivrHQ/quivr#1420 * feat: add security section by @mamadoudicko in QuivrHQ/quivr#1423 * feat: HomePage new footer by @matthieujacq in QuivrHQ/quivr#1425 * feat: add testimonials section by @mamadoudicko in QuivrHQ/quivr#1427 * refactor(backend): cleaning dead and unused code by @StanGirard in QuivrHQ/quivr#1432 **Full Changelog**: QuivrHQ/quivr@v0.0.93...v0.0.94 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Epic: #1232
Issue: #1418
Checklist before requesting a review
Screenshots (if appropriate):