feat: remove onboarding's feature flag

[matthieujacq]

Description

US: #1490

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2023 0:20am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2023 0:20am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2023 0:20am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/hooks/useOnboarding.ts

The changes in this file seem to be safe. However, the chatId variable is being used without checking if it is undefined. This could potentially lead to a runtime error. Consider adding a null check for chatId.

const shouldDisplayOnboardingAInstructions =
chatId !== undefined && shouldDisplayWelcomeChat;

This will ensure that shouldDisplayOnboardingAInstructions is not undefined if chatId is undefined. There are no secrets or API keys exposed in the code.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/ChatDialogue.tsx

The changes in this file seem to be safe. However, the useOnboarding hook is being used without checking if it returns a valid object. This could potentially lead to a runtime error if the hook does not return an object. Consider adding a null check for the useOnboarding hook.

const { isOnboarding } = useOnboarding() || {};

This will ensure that isOnboarding is not undefined if useOnboarding does not return an object.

---

🔍🐛🔧

---

Powered by Code Review GPT