Parallel environments support & RL toolkit - #699
Conversation
for more information, see https://pre-commit.ci
…Gibson into rl-multiple-envs
for more information, see https://pre-commit.ci
…Gibson into rl-multiple-envs
There was a problem hiding this comment.
Awesome work @hang-yin @sujaygarlanka !!!
General thoughts (sorry writing these as they come up during review so they're a bit unorganized):
-
prim_path seems to be the ultimate "unique identifier" for all object classes in our stack -- maybe we always have REGISTRIES use them in named dictionaries for keeping track of stuff? e.g.: StatefulObject.OBJECTS = {obj.prim_path: obj}, sim.scenes = {scene.prim_path: scene}, etc.
-
pose getting: in a vec env, are object's poses automatically offset wrt their env offset? (TODO: add
get_position_orientation_wrt_scene) -
suggestion: unify all pose getters / setters into a single "get/set_pose", which takes in an arg
frame: one of {parent, scene, world} (TODO: discuss with Cem @cgokmen )
Parallel environments support & RL toolkit
Please read below changelog prior to reviewing huge PR!
I designed this PR but major thanks to @sujaygarlanka for initial implementation and @hang-yin for tying up the hundreds of loose ends.
Major changes:
Minor changes:
Caveats: