[Enhancement] Optimize bitshuffle and crc for ARM #44607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> s Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
satanson
approved these changes
Apr 26, 2024
stdpain
approved these changes
Apr 26, 2024
kevincai
approved these changes
Apr 26, 2024
sduzh
approved these changes
Apr 26, 2024
|
@mergify backport branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit 92e6bf6)
42 tasks
|
@mergify backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit 92e6bf6)
42 tasks
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
Apr 28, 2024
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 28, 2024
kangkaisen
pushed a commit
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Optimize performance on the ARM platform.
What I'm doing:
Bitshuffle
Thanks for [arm64] use a better translation for move_mask kiyo-masui/bitshuffle#140. Apply this patch to optimize bishuffle.
CRC
Use NEON
__crc32cwintrinsic to optimizecrc32c::Extend.Use
__ARM_NEONinstead of__ARM_NEON____ARM_NEON__is a legacy, and isn't defined in ARM v8. ARM v8 only defines__ARM_NEON. Since we have already compiled with-march=armv8-a+crc, it is safe to replace__ARM_NEON__with__ARM_NEON.See ARM C Language Extensions, GCC, and Stack Overflow for detail.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: