[BugFix] Disable Gin for shared data mode and alter gin column into non-string type #44970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-string type Fix two problem: 1. Disable using Gin in shared data mode. 2. Disable modify column with Gin into non-string type Signed-off-by: srlch <linzichao@starrocks.com>
| if (index.getIndexType() == IndexDef.IndexType.GIN) { | ||
| if (index.getColumns().contains(oriColumn.getName()) && | ||
| !modColumn.getType().isStringType()) { | ||
| throw new DdlException("Can't not modify a Column with Gin into Non-String type"); |
There was a problem hiding this comment.
Suggested change
| throw new DdlException("Can't not modify a Column with Gin into Non-String type"); | |
| throw new DdlException("Cannot modify a column with GIN into non-string type"); |
nshangyiming
previously approved these changes
Apr 29, 2024
Signed-off-by: srlch <linzichao@starrocks.com>
nshangyiming
previously approved these changes
Apr 29, 2024
packy92
previously approved these changes
Apr 29, 2024
packy92
previously approved these changes
Apr 29, 2024
nshangyiming
previously approved these changes
Apr 29, 2024
wyb
reviewed
Apr 30, 2024
fe/fe-core/src/test/java/com/starrocks/analysis/GINIndexTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: srlch <linzichao@starrocks.com>
|
wyb
approved these changes
Apr 30, 2024
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 8 / 8 (100.00%) file detail
|
packy92
approved these changes
Apr 30, 2024
nshangyiming
approved these changes
Apr 30, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
42 tasks
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
May 9, 2024
…on-string type (StarRocks#44970) Signed-off-by: srlch <linzichao@starrocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two problem:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: