Support curveTo #1

Merged
merged 1 commit into from Oct 8, 2012

Projects

None yet

3 participants

@leethomason

A simple, initial implementation of curveTo(). A couple areas of improvement are in the notes; I'm happy to tune the function, but wanted to get unblocked from the API not being present at all.

@jonathanrpace
Member

Great! Don't suppose you fancy tackling cubicCurveTo while you're there? :)

One suggestion - is it worth passing the 'numDivisions' as an optional parameter, with a default value of 8? That way if people need to tweak it, there's no need to open up the class.

@robsilv
Member
robsilv commented Oct 6, 2012

Thanks Lee, your contributions are obviously very welcome! :D

@leethomason

@jonathanrpace, Good reminder on the cubics. Beginning of the week I'll add the cubics, and also add a proper error metric for the quadratics so it can compute a reasonable number of "numDivisions" for you. That will be much better than the current hardcoded value, and if we stiff need tuning that can be added later.

@robsilv You are welcome - glad to see this getting momentum!

@jonathanrpace jonathanrpace merged commit 0e711d3 into StarlingGraphics:master Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment