Support curveTo #1

Merged
merged 1 commit into from Oct 8, 2012

Conversation

Projects
None yet
3 participants
@leethomason
Contributor

leethomason commented Oct 5, 2012

A simple, initial implementation of curveTo(). A couple areas of improvement are in the notes; I'm happy to tune the function, but wanted to get unblocked from the API not being present at all.

@jonathanrpace

This comment has been minimized.

Show comment
Hide comment
@jonathanrpace

jonathanrpace Oct 6, 2012

Member

Great! Don't suppose you fancy tackling cubicCurveTo while you're there? :)

One suggestion - is it worth passing the 'numDivisions' as an optional parameter, with a default value of 8? That way if people need to tweak it, there's no need to open up the class.

Member

jonathanrpace commented Oct 6, 2012

Great! Don't suppose you fancy tackling cubicCurveTo while you're there? :)

One suggestion - is it worth passing the 'numDivisions' as an optional parameter, with a default value of 8? That way if people need to tweak it, there's no need to open up the class.

@robsilv

This comment has been minimized.

Show comment
Hide comment
@robsilv

robsilv Oct 6, 2012

Member

Thanks Lee, your contributions are obviously very welcome! :D

Member

robsilv commented Oct 6, 2012

Thanks Lee, your contributions are obviously very welcome! :D

@leethomason

This comment has been minimized.

Show comment
Hide comment
@leethomason

leethomason Oct 6, 2012

Contributor

@jonathanrpace, Good reminder on the cubics. Beginning of the week I'll add the cubics, and also add a proper error metric for the quadratics so it can compute a reasonable number of "numDivisions" for you. That will be much better than the current hardcoded value, and if we stiff need tuning that can be added later.

@robsilv You are welcome - glad to see this getting momentum!

Contributor

leethomason commented Oct 6, 2012

@jonathanrpace, Good reminder on the cubics. Beginning of the week I'll add the cubics, and also add a proper error metric for the quadratics so it can compute a reasonable number of "numDivisions" for you. That will be much better than the current hardcoded value, and if we stiff need tuning that can be added later.

@robsilv You are welcome - glad to see this getting momentum!

jonathanrpace added a commit that referenced this pull request Oct 8, 2012

@jonathanrpace jonathanrpace merged commit 0e711d3 into StarlingGraphics:master Oct 8, 2012

IonSwitz added a commit that referenced this pull request Oct 24, 2013

Merge pull request #1 from StarlingGraphics/master
Pulling the Master to the IonSwitz fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment