From c5066e7575e8dd8125bc9a9f96aa0816a001c0ed Mon Sep 17 00:00:00 2001
From: Mark Taylor <m.b.taylor@bristol.ac.uk>
Date: Thu, 9 Nov 2017 16:15:17 +0000
Subject: [PATCH] splat: avoid nom.tam.fits.HeaderCard(String) constructor

The FitsConstants.createHeaderCard(String) method works on all known
versions of nom.tam.fits; the HeaderCard(String) constructor does
not exist in recent versions.
---
 .../uk/ac/starlink/splat/data/FITSSpecDataImpl.java    | 10 +++++-----
 .../uk/ac/starlink/splat/data/MEMSpecDataImpl.java     |  2 +-
 .../uk/ac/starlink/splat/data/NDFSpecDataImpl.java     |  4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/splat/src/main/uk/ac/starlink/splat/data/FITSSpecDataImpl.java b/splat/src/main/uk/ac/starlink/splat/data/FITSSpecDataImpl.java
index 267bea425e..6d7f8380f5 100644
--- a/splat/src/main/uk/ac/starlink/splat/data/FITSSpecDataImpl.java
+++ b/splat/src/main/uk/ac/starlink/splat/data/FITSSpecDataImpl.java
@@ -202,7 +202,7 @@ public String getProperty( String key )
             // All FITS keywords are uppercase.
             String scard = getFitsHeaders().findKey( key.toUpperCase() );
             if ( scard != null ) {
-                HeaderCard card = new HeaderCard( scard );
+                HeaderCard card = HeaderCard.create( scard );
                 if ( card != null ) {
                     return card.getValue();
                 }
@@ -371,7 +371,7 @@ protected void openForRead( String fileName )
                 scard = getFitsHeaders().findKey( "UNITS" );
             }
             if ( scard != null ) {
-                HeaderCard card = new HeaderCard( scard );
+                HeaderCard card = HeaderCard.create( scard );
                 if ( card != null ) {
                     setDataUnits( card.getValue() );
                 }
@@ -382,7 +382,7 @@ protected void openForRead( String fileName )
                 scard = getFitsHeaders().findKey( "OBJECT" );
             }
             if ( scard != null ) {
-                HeaderCard card = new HeaderCard( scard );
+                HeaderCard card = HeaderCard.create( scard );
                 if ( card != null ) {
                     setDataLabel( card.getValue() );
                 }
@@ -590,7 +590,7 @@ protected void saveAst( Header header )
                 while ( ok ) {
                     buffer = chan.nextCard();
                     if ( buffer != null && ! "".equals( buffer ) ) {
-                        iter.add( new HeaderCard( buffer ) );
+                        iter.add( HeaderCard.create( buffer ) );
                     }
                     else {
                         ok = false;
@@ -606,7 +606,7 @@ protected void saveAst( Header header )
                 while ( ok ) {
                     buffer = chan.nextCard();
                     if ( buffer != null && ! "".equals( buffer ) ) {
-                        card = new HeaderCard( buffer );
+                        card = HeaderCard.create( buffer );
                         key = card.getKey();
 
                         // Removes existing card and position either
diff --git a/splat/src/main/uk/ac/starlink/splat/data/MEMSpecDataImpl.java b/splat/src/main/uk/ac/starlink/splat/data/MEMSpecDataImpl.java
index 8b69f5d39b..5be4397c37 100644
--- a/splat/src/main/uk/ac/starlink/splat/data/MEMSpecDataImpl.java
+++ b/splat/src/main/uk/ac/starlink/splat/data/MEMSpecDataImpl.java
@@ -189,7 +189,7 @@ public String getProperty( String prop )
         if ( getFitsHeaders() != null ) {
             String scard = getFitsHeaders().findKey( prop );
             if ( scard != null ) {
-                HeaderCard card = new HeaderCard( scard );
+                HeaderCard card = HeaderCard.create( scard );
                 if ( card != null ) {
                     return card.getValue();
                 }
diff --git a/splat/src/main/uk/ac/starlink/splat/data/NDFSpecDataImpl.java b/splat/src/main/uk/ac/starlink/splat/data/NDFSpecDataImpl.java
index 19bfaed7c7..11e69c8485 100644
--- a/splat/src/main/uk/ac/starlink/splat/data/NDFSpecDataImpl.java
+++ b/splat/src/main/uk/ac/starlink/splat/data/NDFSpecDataImpl.java
@@ -187,7 +187,7 @@ public String getProperty( String key )
             if ( headers != null ) {
                 String scard = headers.findKey( key );
                 if ( scard != null ) {
-                    HeaderCard card = new HeaderCard( scard );
+                    HeaderCard card = HeaderCard.create( scard );
                     if ( card != null ) {
                         return card.getValue();
                     }
@@ -212,7 +212,7 @@ public Header getFitsHeaders()
                 Cursor iter = header.iterator();
                 HeaderCard card;
                 for ( int i = 0; i < size; i++ ) {
-                    card = new HeaderCard( theNDF.getFitsHeader( i ) );
+                    card = HeaderCard.create( theNDF.getFitsHeader( i ) );
                     if ( card.isKeyValuePair() ) {
                         iter.add( card.getKey(), card );
                     }