New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade socket client #1

Merged
merged 3 commits into from Jan 9, 2019

Conversation

2 participants
@hannajones
Copy link
Collaborator

hannajones commented Jan 9, 2019

  • Updated the Socket class to make it compatible with newer versions of stompjs
  • Fixed tests accordingly

@hannajones hannajones requested a review from heldr Jan 9, 2019

@@ -9,7 +9,7 @@
"ts-jest": "^22.4.5"
},
"scripts": {
"test": "jest",
"test": "jest --watch",

This comment has been minimized.

@heldr

heldr Jan 9, 2019

Member

I think that breaks ci test, maybe we create a anoither script "test:watch"

This comment has been minimized.

@hannajones

hannajones Jan 9, 2019

Collaborator

fixed!

@heldr

heldr approved these changes Jan 9, 2019

@heldr heldr merged commit 08c7f17 into master Jan 9, 2019

@heldr heldr deleted the fix-library-upgrades branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment