Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap refactor typography #14

Merged

Conversation

AaronNBrock
Copy link
Collaborator

Overview

This is a bit of a massive PR which refactors all of the typography on the site to use bootstrap's typography, allowing you to more easily configure fonts/font colors. For example, take a look at the new _variables.scss:

//
// Colors
//

// General
$primary: #5d78ff;
$secondary: #282f49;
// Text
$headings-color: #282f49;
$body-color: #7e7e8a;

//
// Typography
//

// Fonts
@import url("https://fonts.googleapis.com/css?family=Poppins:400,500,600,700,800,900|Yeseva+One&display=swap");
$font-family-base: "Poppins", sans-serif;
$headings-font-family: "Yeseva One", cursive;

// Size
$font-size-base: 1.125rem; // 18px
$h1-font-size: 60px;
$h2-font-size: 50px;
$h3-font-size: 30px;
$h4-font-size: 25px;
$h5-font-size: 22px;
$h6-font-size: 16px;

// Spacing
$headings-margin-bottom: 1.5rem;
$line-height-base: 1.75;

// Misc
$link-hover-decoration: none;

And since it's all using bootstrap, you can leverage any other bootstrap typography options too! 馃コ

Breaking Changes

Once again, this does change the visuals a bit. But I've tried my best to approximately match what was there before. But, feel free try this one out to make sure you're happy with it.

Other fixes

Since I was lazy, I bunched a number of other changes into this:

  • Fixed a number of places the colors were hardcoded, the $primary color should change all instances now. (besides those inside of the .svg files)
  • Fixed bug where on mobile there would be a slight horizontal scroll due to the portfolio section
  • Refactored the sections .html files & .scss names to match.
  • Adding configuration options for the social buttons at the bottom, with the new [[params.social]] option in the config.toml
  • Fixed the refactored the contact page buttons (which I forgot to do on Bootstrap refactor buttons聽#6 )
  • Changed the headers of every section to be markdown, so you can have subtitles on whatever section you want!
  • Idk, prolly a few other things.

Btw, thanks for the awesome theme! It's the prettiest hugo theme I've seen 馃槃

@imjuanleonard
Copy link

This is what I am looking for, when will this get merged?

@AaronNBrock AaronNBrock merged commit cf79448 into StaticMania:master Oct 6, 2020
@AaronNBrock
Copy link
Collaborator Author

@imjuanleonard I went ahead and merged it myself.

@kausarpial let me know if there are any changes you're unhappy with & I can create a new PR to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants