New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap refactor typography #14
Merged
AaronNBrock
merged 28 commits into
StaticMania:master
from
AaronNBrock:bootstrap-refactor-typography
Oct 6, 2020
Merged
Bootstrap refactor typography #14
AaronNBrock
merged 28 commits into
StaticMania:master
from
AaronNBrock:bootstrap-refactor-typography
Oct 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what I am looking for, when will this get merged? |
@imjuanleonard I went ahead and merged it myself. @kausarpial let me know if there are any changes you're unhappy with & I can create a new PR to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a bit of a massive PR which refactors all of the typography on the site to use bootstrap's typography, allowing you to more easily configure fonts/font colors. For example, take a look at the new
_variables.scss
:And since it's all using bootstrap, you can leverage any other bootstrap typography options too! 馃コ
Breaking Changes
Once again, this does change the visuals a bit. But I've tried my best to approximately match what was there before. But, feel free try this one out to make sure you're happy with it.
Other fixes
Since I was lazy, I bunched a number of other changes into this:
$primary
color should change all instances now. (besides those inside of the.svg
files).html
files &.scss
names to match.[[params.social]]
option in theconfig.toml
contact
page buttons (which I forgot to do on Bootstrap refactor buttons聽#6 )Btw, thanks for the awesome theme! It's the prettiest hugo theme I've seen 馃槃