-
Notifications
You must be signed in to change notification settings - Fork 96
Rename UPBGE to BlenderGameEngine #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Adobe_AIR = (?:^|/)Adobe AIR(?:$|/) | ||
| AdventureGameStudio = (?:^|/)(?:AGSteam\.dll|acsetup\.cfg)$ | ||
| AGI = (?:^|/)AGIDATA\.OVL$ | ||
| BlenderGameEngine[] = (?:^|/)BlendThumb(?:64|)\.dll$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be too generic and is probably what makes it match Blender or Motion Studio which are not Blender Game Engine nor UPBGE applications.
Could be worth running a test on SteamDB with this rule removed, to see which entries would be removed. I could then have a look and see if they were indeed false positives or not.
Edited description to include both projects which have the same signature. BGE was removed from Blender in 2.80 in 2019, so it's likely that most of the published titles were made with BGE and not the UPBGE fork.
aa5f4bd to
9223dcc
Compare
|
Thanks! I've had a quick look at some of the entries with I tried Inside The Gear which I seemed to own for some reason, here's the complete file listing: There's not much that immediately identifies Blender Game Engine but there are good hints:
No All in all, there's not much to go on with BGE to be 100% sure, but indeed |
|
I didn't review the full list but in terms of false positives with the current heuristics, I think it's mostly just:
So the current state is satisfactory I think. Also to clarify, note that this PR doesn't change the heuristics, it just renames/moves things. |
|
I merged the rename, you can make an issue if you think the detection can be improved. |
SteamDB app page links to a few games using this
https://steamdb.info/app/757860/
https://steamdb.info/app/499460/
https://steamdb.info/app/324240/
https://steamdb.info/app/1209750/ (this one I've confirmed uses UPBGE)
Everything currently under https://steamdb.info/tech/Engine/UPBGE/
Brief explanation of the change
Edited description to include both projects which have the same signature.
BGE was removed from Blender in 2.80 in 2019, so it's likely that most of
the published titles were made with BGE and not the UPBGE fork.
Follow-up to #61 (comment)
Note: I don't know if there's a way to actually differentiate between BGE and UPBGE titles to see if my above assumption is correct. I could be wrong since while BGE was removed from Blender in 2019, UPBGE did start as a fork in 2015 according to their README.
Note 2: Blender itself is matched even though it no longer contains the code for the BGE. So this might also match other non-game applications that bundle parts of Blender, such as Motion Studio which bundles it as an export tool.