Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byteorder-dependency #98

Merged
merged 1 commit into from Aug 5, 2019
Merged

Remove byteorder-dependency #98

merged 1 commit into from Aug 5, 2019

Conversation

lukaslueg
Copy link
Contributor

@lukaslueg lukaslueg commented Aug 3, 2019

This removes the byteorder-dependency, which is unneeded since 1.32 and gets pulled in a lot due to term.

Copy link
Owner

@Stebalien Stebalien left a comment

LGTM modulo the nit about field punning. Could you revert that change?

src/terminfo/mod.rs Outdated Show resolved Hide resolved
@lukaslueg
Copy link
Contributor Author

@lukaslueg lukaslueg commented Aug 5, 2019

I took liberty to rebase and force-push

Copy link
Owner

@Stebalien Stebalien left a comment

Thanks!

@Stebalien Stebalien merged commit c6277a1 into Stebalien:master Aug 5, 2019
2 checks passed
@Stebalien
Copy link
Owner

@Stebalien Stebalien commented Aug 5, 2019

Published so you can remove the dep.

@lukaslueg lukaslueg deleted the byteorder_removed branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants