New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to also return headers #5

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@vionemc
Contributor

vionemc commented Aug 29, 2015

there is a return header option and also the test

@SteelPangolin

This comment has been minimized.

Show comment
Hide comment
@SteelPangolin

SteelPangolin Sep 9, 2015

Owner

Thanks for the PR. I'm reviewing it now.

Owner

SteelPangolin commented Sep 9, 2015

Thanks for the PR. I'm reviewing it now.

@vionemc

This comment has been minimized.

Show comment
Hide comment
@vionemc

vionemc Sep 9, 2015

Contributor

Pease ping me if the update is submitted to python. I'd use the updated version right away for my own app

Contributor

vionemc commented Sep 9, 2015

Pease ping me if the update is submitted to python. I'd use the updated version right away for my own app

@vionemc

This comment has been minimized.

Show comment
Hide comment
@vionemc

vionemc Sep 25, 2015

Contributor

@SteelPangolin the update I made is not submitted to the python library. I can't upgrade it using pip install

Can you please submit it? Thanks

Contributor

vionemc commented Sep 25, 2015

@SteelPangolin the update I made is not submitted to the python library. I can't upgrade it using pip install

Can you please submit it? Thanks

SteelPangolin added a commit that referenced this pull request Oct 10, 2015

@SteelPangolin

This comment has been minimized.

Show comment
Hide comment
@SteelPangolin

SteelPangolin Oct 10, 2015

Owner

Thanks for your code and patience. I've merged your change with some modifications: squashed into a single commit, and with updated comments and extended tests.

6b87ef8

I'll push a new version to PyPI tonight.

Owner

SteelPangolin commented Oct 10, 2015

Thanks for your code and patience. I've merged your change with some modifications: squashed into a single commit, and with updated comments and extended tests.

6b87ef8

I'll push a new version to PyPI tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment