Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support alternative names (designations) for exoplanets #2350

Merged
merged 3 commits into from Mar 16, 2022

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Mar 16, 2022

Description

This patch added support alternative names (designations) for exoplanets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to To do in Plugin: Exoplanets via automation Mar 16, 2022
@github-actions github-actions bot requested a review from gzotti March 16, 2022 10:43
@alex-w alex-w added this to the 0.22.0 milestone Mar 16, 2022
Plugin: Exoplanets automation moved this from To do to In progress Mar 16, 2022
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a more expectable variable and key name, e.g. starAltName or starAliasName, everywhere.
If you think this is really needed, it else seems OK.

@alex-w alex-w merged commit 0ac35fc into master Mar 16, 2022
Plugin: Exoplanets automation moved this from In progress to Done Mar 16, 2022
@alex-w alex-w deleted the exoplanets/extra-designation branch March 16, 2022 18:29
@alex-w alex-w added the state: fixed The bug has been fixed label Mar 20, 2022
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Mar 27, 2022
@github-actions
Copy link

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants