Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MeteorShowers.json #2467

Merged
merged 1 commit into from May 28, 2022
Merged

Update MeteorShowers.json #2467

merged 1 commit into from May 28, 2022

Conversation

worachate001
Copy link
Member

@worachate001 worachate001 commented May 28, 2022

Updates and fixes in new meteor shower database.

Note: ZHR of 15-600 for 2022 τ-Herculids (TAH) is taken from this paper https://arxiv.org/abs/2205.12473

Description

Fixes #2449 (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Update Meteor Shower database
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit 2a06d6c into Stellarium:master May 28, 2022
@alex-w alex-w added this to the 0.22.2 milestone May 28, 2022
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label May 28, 2022
@worachate001 worachate001 deleted the patch-1 branch May 28, 2022 08:57
@alex-w alex-w added the state: fixed The bug has been fixed label May 29, 2022
@github-actions
Copy link

Hello @worachate001! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @worachate001! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEAK DATE FOR TAU HURCULIDS METEOR SHOWER
2 participants