New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way the module builds #98

Open
bateskevin opened this Issue Oct 18, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@bateskevin
Copy link
Contributor

bateskevin commented Oct 18, 2018

Change the way the module builds

The module is getting to big to dot source all the functions.

Part of a build should be to generate the psm1 file with all the Functions and (eventually) classes in it.

This will increase the import time of the module drastically.

@Stephanevg

This comment has been minimized.

Copy link
Owner

Stephanevg commented Oct 18, 2018

Completley agree on this one @bateskevin . I wanted to do this one already before, simply didnt got to it yet.

I think some things need to be taken into consideration:

Classes need to be loaded in order. I know we don't have any yet, but this will change in the near feature.

Therefore, the build script should read the order of the classes to load from a psd1 file.

here is an example of build script from Christ Gardner we could use as starter: https://github.com/FrPSUG/Presentations/blob/master/20180915-Module_Development_Best_Practices(Chris_Gardner)/build.ps1

As a general note: The build Script should be completley independant of any external module to be able to build the module.

@ChendrayanV

This comment has been minimized.

Copy link
Contributor

ChendrayanV commented Jan 10, 2019

This request is very valid. When we are building static web pages, module load time is not that important. But, to render it on web page, it is much focused. Due to module load time the PSHTML used in node.js takes 58 seconds to render the output.

@Stephanevg @bateskevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment