New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for using builder pattern #1
Open
friism
wants to merge
3
commits into
SteveLasker:master
Choose a base branch
from
friism:add-instructions
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
FROM microsoft/aspnetcore-build:1.0.1 | ||
|
||
RUN mkdir /app | ||
WORKDIR /app | ||
|
||
ADD project.json . | ||
RUN dotnet restore --no-cache | ||
|
||
ADD . . | ||
RUN dotnet publish --output /out/. --configuration Release | ||
ADD Dockerfile.deploy /out/Dockerfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
FROM microsoft/dotnet:1.0.1-core | ||
|
||
RUN mkdir /app | ||
WORKDIR /app | ||
ADD . . | ||
|
||
CMD dotnet app.dll |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,17 @@ | ||
# BuildASPDotNetInAContainer | ||
Sample used to build and test an ASP.NET Core Web app in a container | ||
|
||
# Builder container pattern | ||
|
||
Here's how to build the app in a container with the full .NET Core SDK, publish, export and then import in a smaller runtime container image: | ||
|
||
1. `cd BuildOptimizedImages\src\Web` | ||
2. `$image_id = docker build -q .` | ||
3. `$container_id = docker create $image_id.split(":")[1]` | ||
4. `$tmp_folder_name = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath() + [System.IO.Path]::GetRandomFileName())` | ||
5. `mkdir $tmp_folder_name` | ||
6. ``docker cp $container_id`:/out $tmp_folder_name`` | ||
7. `docker rm $container_id` | ||
8. `docker build -t app $tmp_folder_name\out` | ||
9. `Remove-Item -Recurse -Force $tmp_folder_name` | ||
10. `docker run app` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a compelling reason to do --no-cache here? You are slowing down the restore for no real gain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because I had misunderstood what the flag does: aspnet/MusicStore#713 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. That makes sense. Yeah, we probably should talk about clarifying the descriptions and such if it is still the same.