-
Notifications
You must be signed in to change notification settings - Fork 203
Fix arm64 build #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arm64 build #303
Conversation
The cmake module was located in another folder.
|
That actually does make a lot of sense! I was under the (wrong) impression that |
The cmake module was located in another folder.
|
I'm backporting and releasing jazzy again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be good to do conditionally or with a variable substitution so as not to pollute the path with unused elements.
|
@tfoote can you give me some pointers on which conditions this should be enabled. Alternatively, what about searching for OpenVDBConfig.cmake in all paths under /usr and adding the parent folder? |
|
In this case you should only be appending the path for the current architecture. Right now you're appending the path for both architectures, which probably will be ok, but could give some very weird errors if someone happens to be doing some multi-arch builds and it picks up the wrong architecture from their system. I don't have the exact commands but GNUInstallDirs is commonly used for picking the installation targets like this: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#result-variables so I presume it should be able to help set the search path. Otherwise you could simply check the arch in your CMake manually and then extend the CMAKE_MODULE_PATH conditionally. |
|
Good idea.
Do you have an example of best practices for this? I see ways of doing it with |
|
In the cmake these variables are available that could be of use: A solution could be to append |
The cmake module was located in another folder.