Port JSSpec and qunit tests over to Jasmine#718
Conversation
…lect an expectation
… phantom.runner.js.
|
Wow, thanks so much for doing this! It might take a few days for us to go through this and be sure we're ready to merge it in, but I'll be so pleased to switch over to Jasmine (and not have the weird JsSpec/QUnit combination). |
|
This is great! I use Jasmine for all of my other repositories and am very happy with it. I think that it will be good for us to use it. I think that we could get good use out of Jasmine's spies as well to simplify some cases, but a 1:1 port of the old tests seems like the best place to start. |
|
This is a great change! I've created a local branch for this and made some changes: master...718-Jasmine-tests |
|
Fantastic. I've been through this in some detail and still think it looks great :) I added a couple more tweaks to the local branch that Michael created, but nothing significant. Michael, could you clarify the point about |
|
Sorry I forgot to include it. It's just a simple tweak to hide the html used by the tests. |
|
OK great, merged in. Thanks again Chris, this is really valuable! |
|
yay! Nice work @chrisprice :) |
|
Awesome, thanks gents! And now it's in, no one will ever know how much horrendous regex went into this change...opps... :) |
As a pre-cursor to running some tests out of the browser for #712, something unsupported by JSSpec, I've had a go at porting all of the test specs over to use Jasmine. This has a number of benefits -
The jasmine API is very similar to the JSSpec one so most of the porting isn't very controversial. However, there are three commits worth drawing attention to -
I've run the tests successfully on all the browsers I have access to.
I hope this change isn't too controversial, I noticed on the mailing list that lots of people were using jasmine for their own tests.
Chris