API doesn't take changed arrive/depart times in to account #3

Closed
skywave opened this Issue Apr 5, 2012 · 8 comments

Projects

None yet

3 participants

@skywave
skywave commented Apr 5, 2012

Currently the API only uses the current time even if the time is changed in the parameter.

@skywave skywave was assigned Apr 5, 2012
@skinkie
skinkie commented Apr 5, 2012

On Thu, 5 Apr 2012, skywave wrote:

Currently the API only uses the current time even if the time is changed in the parameter.

Is this a fault at our side or upstream?

Stefan

@skywave
skywave commented Apr 5, 2012

Can't test, but there aren't much changes here to the API. So will upgrade this issue upstream soon.
AFAIK it was still working a couple of days ago. Back then the website was using 12 hour time format, but accepted 24 hour format. Also it's broken with the old 12 hour format aswell.
Haven't seen many suspect commits. Date format was changed to ISO8601, seemingly not affecting times.
e2005b2
DST fixes but those only impact the routing.
0b4efb3
Stoptime filtering, only impacts GTFS reading
aeab973

@skinkie
skinkie commented Apr 5, 2012

I guess Joel is the one that can really clue us in.

@skywave
skywave commented Apr 6, 2012

Problemen was known upstream as #666 and was fixed 3 days ago

@skywave skywave closed this Apr 6, 2012
@joelhaasnoot

@skywave Did you pull otp_nl and does it now work? Because I pulled everything from the upstream master last night and built and believe @skinkie restarted it all and it sill doesn't work. The only commit that's you added is related to something elevation (which we don't use).

@skywave
skywave commented Apr 6, 2012

Yes i tested it locally but let me recheck. Thought this was the fixing commit
50c7528

@joelhaasnoot

I rebuilt everything just now, would just need a restart from @skinkie

@skywave
skywave commented Apr 6, 2012

Yes it it is working locally on branch otp_nl. See screenshot http://imgur.com/AIDQU
I do see your merge (a5b821c) contains the same patch to DateUtils.java as my merge (5765fc0). So you're probably right about the patch already in there at 21hours.
Most likely i didnt fetch after your merge, which would explain my build at midnight had this same bug, but after i merged (which complained about fast forward btw ) it was solved. Could it be that somehow with this compile this patch was left out? Otherwise i can upload the api-webapp build on this computer

@skywave skywave removed their assignment Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment