Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coveralls from CircleCI config #3929

Merged
merged 1 commit into from Aug 14, 2019
Merged

Remove coveralls from CircleCI config #3929

merged 1 commit into from Aug 14, 2019

Conversation

drewvolz
Copy link
Member

at least it's not a 503 today

We're hitting a 405 on our PRs, so let's say goodbye for now.

@drewvolz drewvolz requested review from hawkrives and rye August 13, 2019 17:14
@drewvolz
Copy link
Member Author

I checked to see the usage with ripgrep after this commit.

$ rg -i coveralls --iglob=[!./node_modules] ./*

./CHANGELOG.md
89:- Removed coveralls coverage reporting

@rye
Copy link
Member

rye commented Aug 13, 2019

Would it be worth replacing with codecov?

@drewvolz
Copy link
Member Author

I think it'd be nice to have a replacement. Would it make sense to have that be a follow-up to this PR instead of as a part of this?

@rye
Copy link
Member

rye commented Aug 13, 2019

I think that'd be suited to go into this PR

@hawkrives hawkrives merged commit db2a775 into master Aug 14, 2019
@hawkrives hawkrives deleted the nix-coveralls branch August 14, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkrives hawkrives hawkrives approved these changes

@rye rye Awaiting requested review from rye rye is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewvolz @rye @hawkrives