Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Co-op replays #39

Merged
merged 53 commits into from May 18, 2018
Merged

Add support for Co-op replays #39

merged 53 commits into from May 18, 2018

Conversation

@StoicLoofah
Copy link
Owner

@StoicLoofah StoicLoofah commented May 15, 2018

Good news: spawningtool now supports parsing co-op replays! Bad news: I rewrote pretty much everything.

A lot of notable changes in here:

  1. Added command line arguments for what data is printed to the console. This was primarily for convenience of testing
  2. Added coop_constants.py, where data is classified by commander. This is important because the same unit has different data depending on the commander (e.g. Raynor's rapid recruitment builds units faster than other commanders).
  3. Added a bunch of new optional fields onto the BUILD_DATA values: display_name, race, type, is_morph. this centralizes data spread across here and 2 places in the Spawning Tool web app backend.
  4. completely rewrote the parser into using a class wrapper. This was helpful because we need a ton of context at even the lowest level functions to grab the right data for a commander, and it encapsulated all of it without passing a dozen variables as parameters
  5. added a ton of logic and fields for co-op and specific commanders
  6. Build orders data now outputs with display_name if possible.

Future work includes adding a ton more data around hots_constants and lotv_constants for consistency.

StoicLoofah added 4 commits May 18, 2018
@StoicLoofah StoicLoofah merged commit 74fb190 into master May 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@StoicLoofah StoicLoofah deleted the coop branch May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.