-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for Co-op replays #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news: spawningtool now supports parsing co-op replays! Bad news: I rewrote pretty much everything.
A lot of notable changes in here:
coop_constants.py, where data is classified by commander. This is important because the same unit has different data depending on the commander (e.g. Raynor's rapid recruitment builds units faster than other commanders).BUILD_DATAvalues:display_name,race,type,is_morph. this centralizes data spread across here and 2 places in the Spawning Tool web app backend.display_nameif possible.Future work includes adding a ton more data around
hots_constantsandlotv_constantsfor consistency.