fix cors config & update helmet #92

bryanchriswhite · 2017-11-04T12:48:03Z

No description provided.

phutchins

I'd like to test through our SDK as we run in production mode there and use self signed certs without a storj.io domain. Could we add an ENV var to override the corsRegex if it exists?

braydonf · 2017-11-07T19:23:26Z

lib/engine.js

-    origin: true,
-    credentials: true
-  }));
+  app.use(crossorigin());


corsOptions should go here

fix cors config & update helmet

541617d

bryanchriswhite added the needs review label Nov 4, 2017

bryanchriswhite requested a review from phutchins November 4, 2017 12:48

phutchins reviewed Nov 4, 2017

View reviewed changes

braydonf reviewed Nov 7, 2017

View reviewed changes

lib/engine.js Outdated

origin: true,

credentials: true

}));

app.use(crossorigin());

Copy link

Contributor

braydonf Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corsOptions should go here

actually use cors options

ade5dc3

braydonf merged commit 3670c60 into storj-archived:master Nov 7, 2017

storj-archived deleted a comment from coveralls Nov 7, 2017

braydonf removed the needs review label Nov 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix cors config & update helmet #92

fix cors config & update helmet #92

bryanchriswhite commented Nov 4, 2017

phutchins left a comment

braydonf Nov 7, 2017

fix cors config & update helmet #92

fix cors config & update helmet #92

Conversation

bryanchriswhite commented Nov 4, 2017

phutchins left a comment

Choose a reason for hiding this comment

braydonf Nov 7, 2017

Choose a reason for hiding this comment