This repository has been archived by the owner. It is now read-only.

storjshare should set non-zero exit code on failure #335

Closed
mtlynch opened this Issue Apr 2, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@mtlynch

mtlynch commented Apr 2, 2018

Package Versions

$ storjshare --version
daemon: 5.3.1, core: 8.7.2, protocol: 1.2.0

$ node --version
v8.11.1

Steps to Reproduce

Attempt to start a farmer with an incomplete config file:

$ storjshare daemon
$ wget https://raw.githubusercontent.com/Storj/storjshare-daemon/master/example/farmer.config.json
$ storjshare start --config farmer.config.json

  failed to start node, reason: invalid payout address
$ echo $?
0

Expected Behavior

Exit code is set to a non-zero value, to represent failure, e.g.

$ echo $?
1

Actual Behavior

Exit code is set to zero, implying success:

$ echo $?
0

This creates problems for developers who wish to write shell scripts or use configuration management tools to automate deployment.

@RichardLitt

This comment has been minimized.

Member

RichardLitt commented Oct 30, 2018

👋 Hey! Thanks for this contribution. Apologies for the delay in responding!

We've decided to rearchitect Storj, so that we can scale better. You can read more about this decision here. This means that we are entirely focused on v3 at the moment, in the storj/storj repository. Our white paper for v3 is coming very, very soon - follow along on the blog and in our Rocketchat.

As this repository is part of the v2 network, we're no longer maintaining this repository. I am going to close this for now. If you have any questions, I encourage you to jump on Rocketchat and ask them there. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.