New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/frontpage query sending wrong time for graphs. #845

Closed
rainfarmer opened this Issue Nov 22, 2016 · 13 comments

Comments

Projects
None yet
4 participants
@rainfarmer
Contributor

rainfarmer commented Nov 22, 2016

/frontpage query sending wrong time for graphs.

For all front page graphs, it is sending time like:
"TimeMin": 0.0028038053600941749,
"TimeMax": 0.0028038053650438679

Even if the server time is older than 0.002
And I think timeMin should usually be 0

https://gyazo.com/b5d39ed79054b3fa02e3676acf65a94f

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Nov 30, 2016

So I can switch all the timeMins to being 0 by changing a default value - but there seems to be a special system in place to toggle between timeMin being 0 and being the same as timeMax... so not really sure why that would be put there deliberately.

As for the time being wrong, I don't immediately see any issues. The graphs (and thus time stamps) will only be refreshed every 10 minutes no matter how many times you call front page - could that be what you're seeing? Or is timeMax still staying at such a low value even after minutes or hours?

MarjieAVolk commented Nov 30, 2016

So I can switch all the timeMins to being 0 by changing a default value - but there seems to be a special system in place to toggle between timeMin being 0 and being the same as timeMax... so not really sure why that would be put there deliberately.

As for the time being wrong, I don't immediately see any issues. The graphs (and thus time stamps) will only be refreshed every 10 minutes no matter how many times you call front page - could that be what you're seeing? Or is timeMax still staying at such a low value even after minutes or hours?

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Nov 30, 2016

Wait no I've found it now... the 10 minute delay thing isn't done properly. Okay, will send fix shortly

MarjieAVolk commented Nov 30, 2016

Wait no I've found it now... the 10 minute delay thing isn't done properly. Okay, will send fix shortly

@rainfarmer

This comment has been minimized.

Show comment
Hide comment
@rainfarmer

rainfarmer Dec 6, 2016

Contributor

The graphs from the /frontpage query are still giving off timing, when the time is before 1 day

You can see /timerange query shows 0.05 days
https://gyazo.com/7a03a48240ff47f04d2b9e854a32633c

And /frontpage query graph is showing time of 0.01 https://gyazo.com/b3f890b41c0c61f026e98483c82bccba

Should be displaying 0.05 days for the /frontpage query graphs.
Note: we display graphs below 1 day, at 2 decimal places, rounded down.

Contributor

rainfarmer commented Dec 6, 2016

The graphs from the /frontpage query are still giving off timing, when the time is before 1 day

You can see /timerange query shows 0.05 days
https://gyazo.com/7a03a48240ff47f04d2b9e854a32633c

And /frontpage query graph is showing time of 0.01 https://gyazo.com/b3f890b41c0c61f026e98483c82bccba

Should be displaying 0.05 days for the /frontpage query graphs.
Note: we display graphs below 1 day, at 2 decimal places, rounded down.

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 6, 2016

Hmm, so I don't see this problem on my local server just now; but it has been running for more than one day. You're seeing that when the time is lower than one day, it's a problem, and after one day it is fixed? Or all the servers you're testing just happen to be younger than one day?

MarjieAVolk commented Dec 6, 2016

Hmm, so I don't see this problem on my local server just now; but it has been running for more than one day. You're seeing that when the time is lower than one day, it's a problem, and after one day it is fixed? Or all the servers you're testing just happen to be younger than one day?

@rainfarmer

This comment has been minimized.

Show comment
Hide comment
@rainfarmer

rainfarmer Dec 7, 2016

Contributor

In my test approx. before 1 day, the error happens, but approx. after one day it does not happen.

I'm not sure the exact time it works and doesnt.

You can reset the server and generate data with this query to test:
http://localhost:3001/datasets/generatetestdata?users=5&days=0.05&generateClimateData=true

Contributor

rainfarmer commented Dec 7, 2016

In my test approx. before 1 day, the error happens, but approx. after one day it does not happen.

I'm not sure the exact time it works and doesnt.

You can reset the server and generate data with this query to test:
http://localhost:3001/datasets/generatetestdata?users=5&days=0.05&generateClimateData=true

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 8, 2016

So yeah, I haven't found any wrong behavior yet... I'm not 100% sure that it's wrong, because there are a few different things that get updated at different delays, so within a time range of < 1 hour there will be some inexact time stamps.

MarjieAVolk commented Dec 8, 2016

So yeah, I haven't found any wrong behavior yet... I'm not 100% sure that it's wrong, because there are a few different things that get updated at different delays, so within a time range of < 1 hour there will be some inexact time stamps.

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 8, 2016

Wait a second... I did just find something impossible. Okay continuing to investigate lol

MarjieAVolk commented Dec 8, 2016

Wait a second... I did just find something impossible. Okay continuing to investigate lol

@noblackthunder

This comment has been minimized.

Show comment
Hide comment
@noblackthunder

noblackthunder Dec 8, 2016

=) typical .. when you think nope its all ok you suddenly see it ;)

noblackthunder commented Dec 8, 2016

=) typical .. when you think nope its all ok you suddenly see it ;)

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 8, 2016

Alright no, I got unconfused again I think.

So yeah, I haven't seen this behavior that you're seeing during my fiddling with the web API. From what I understand, the time stamps coming from /timerange get updated once every 30 minutes, while the time stamps coming from /frontpage get updated once every 10 minutes.

So the /frontpage time should never be more than 10 minutes smaller than the /timerange time. Which is not true in the example you gave me. So yeah I have no idea what is going on. Are you on a different branch that didn't get the fix or anything like that?

MarjieAVolk commented Dec 8, 2016

Alright no, I got unconfused again I think.

So yeah, I haven't seen this behavior that you're seeing during my fiddling with the web API. From what I understand, the time stamps coming from /timerange get updated once every 30 minutes, while the time stamps coming from /frontpage get updated once every 10 minutes.

So the /frontpage time should never be more than 10 minutes smaller than the /timerange time. Which is not true in the example you gave me. So yeah I have no idea what is going on. Are you on a different branch that didn't get the fix or anything like that?

@rainfarmer

This comment has been minimized.

Show comment
Hide comment
@rainfarmer

rainfarmer Dec 9, 2016

Contributor

I was using marjie-teachertools, ill retry.

Did you use this query or another method to generate data?
http://localhost:3001/datasets/generatetestdata?users=5&days=0.05&generateClimateData=true

Contributor

rainfarmer commented Dec 9, 2016

I was using marjie-teachertools, ill retry.

Did you use this query or another method to generate data?
http://localhost:3001/datasets/generatetestdata?users=5&days=0.05&generateClimateData=true

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 9, 2016

I've primarily been just playing myself to get data

MarjieAVolk commented Dec 9, 2016

I've primarily been just playing myself to get data

@MarjieAVolk

This comment has been minimized.

Show comment
Hide comment
@MarjieAVolk

MarjieAVolk Dec 15, 2016

Did you ever conclude whether this was fixed on master?

MarjieAVolk commented Dec 15, 2016

Did you ever conclude whether this was fixed on master?

@rainfarmer

This comment has been minimized.

Show comment
Hide comment
@rainfarmer

rainfarmer Dec 19, 2016

Contributor

Its ok,

I think I was just noticing that the /frontpage query and the /timerange query display different times, as you said, based on their update cycle.

Contributor

rainfarmer commented Dec 19, 2016

Its ok,

I think I was just noticing that the /frontpage query and the /timerange query display different times, as you said, based on their update cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment