Skip to content

Fix square styling error when using multiple fonts in font family sty… #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2025
Merged

Fix square styling error when using multiple fonts in font family sty… #2607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3880f9c
Fix square styling error when using multiple fonts in font family sty…
Crabcyborg Nov 27, 2025
f46d92c
Move font family logic to a new function
Crabcyborg Nov 27, 2025
2a30f66
Remove old comment
Crabcyborg Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions square/controllers/FrmSquareLiteActionsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,6 @@ private static function get_style( $form_id ) {
'backgroundColor' => $settings['bg_color'],
'fontWeight' => $settings['field_weight'],
),
// How does input placeholder work??
'input::placeholder' => array(
'color' => $settings['text_color_disabled'],
),
Expand All @@ -580,7 +579,7 @@ private static function get_style( $form_id ) {
);

if ( ! empty( $settings['font'] ) ) {
$style['input']['fontFamily'] = $settings['font'];
$style['input']['fontFamily'] = self::prepare_font_family_setting( $settings['font'] );
}

/**
Expand All @@ -593,6 +592,23 @@ private static function get_style( $form_id ) {
return apply_filters( 'frm_square_style', $style, $settings, $form_id );
}

/**
* Prepare the font family setting for the Stripe element.
*
* @since x.x
*
* @param string $font
* @return string
*/
private static function prepare_font_family_setting( $font ) {
if ( false === strpos( $font, ',' ) ) {
return $font;
}

$fonts = explode( ',', $font );
return trim( reset( $fonts ) );
}

/**
* Get the border radius for Stripe elements.
*
Expand Down
Loading