Permalink
Browse files

make dataset id optional when skipping export

  • Loading branch information...
aleemstreak committed Oct 10, 2012
1 parent ae3e6b7 commit cdc198cdae0d40a95e518037fa5cad6e0413afdf
View
@@ -288,3 +288,4 @@ We've been working on this functionality or a little bit of time but recently Go
3. Create a class which implements <code>BuiltinDatastoreExportConfiguration</code>
4. Call <code>/bqlogging/builtinDatastoreExport?builtinDatastoreExportConfig=</code><the fully qualified class name that you implemented>
+You can put this call in your cron.xml to have the bigquery tables updated periodically. Checkout the documentation in <code>BuiltinDatastoreExportConfiguration</code>.
View
Binary file not shown.
@@ -53,8 +53,9 @@ public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOExc
String bucketName = exporterConfig.getBucketName();
String bigqueryDatasetId = exporterConfig.getBigqueryDatasetId();
String bigqueryProjectId = exporterConfig.getBigqueryProjectId();
+ boolean skipExport = exporterConfig.shouldSkipExportToBigquery();
- if (!AnalysisUtility.areParametersValid(bucketName, bigqueryDatasetId, bigqueryProjectId)) {
+ if (!AnalysisUtility.areParametersValid(bucketName, bigqueryProjectId) || (!skipExport && !AnalysisUtility.areParametersValid(bigqueryDatasetId))) {
resp.getWriter().write(AnalysisUtility.failureJson("Exporter config returned null for one of the params"));
resp.setStatus(HttpServletResponse.SC_BAD_REQUEST);
return;

0 comments on commit cdc198c

Please sign in to comment.