Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make versionned releases #8

Closed
anarcat opened this issue Jun 20, 2017 · 7 comments
Closed

make versionned releases #8

anarcat opened this issue Jun 20, 2017 · 7 comments

Comments

@anarcat
Copy link
Contributor

anarcat commented Jun 20, 2017

hello again! :)

i was surprised to find an API change when my CI failed here... Turns out that GetEntries now needs a callback, which is fine, but i didn't expect such a change without a version number bump.

i encourage you to tag releases and use the semver.org standard for naming those versions. if there would have been a major (or even minor) version bump I would have been more careful before doing my own releases...

@Strubbl
Copy link
Owner

Strubbl commented Jun 20, 2017

Sorry. Yes, you are right. I was too lazy so far. But in future i will version a bit more. But that would mean you will have to rely on tags instead of the head of master. Is that okay for you?

@Strubbl
Copy link
Owner

Strubbl commented Jun 20, 2017

I have created two tags now. Current version is 1.0.0. The latest working version before i changed and added a lot of API calls is v0.1.0
So far i have only used git tags. I think it would make sense to put the version string somewhere in the source code, so that when you download the v0.1.0.zip, unzip it to the folder wallabago/ and later want to know which release it was, that would be helpful.
But where to put a version number? In the readme only? Any idea or thoughts on that @anarcat ?

@anarcat
Copy link
Contributor Author

anarcat commented Jun 20, 2017

Sorry. Yes, you are right. I was too lazy so far. But in future i will version a bit more. But that would mean you will have to rely on tags instead of the head of master. Is that okay for you?

Not sure what that means, but that's pretty much what i want i think. :)

I have created two tags now. Current version is 1.0.0. The latest working version before i changed and added a lot of API calls is v0.1.0

Thanks!

So far i have only used git tags. I think it would make sense to put the version string somewhere in the source code, so that when you download the v0.1.0.zip, unzip it to the folder wallabago/ and later want to know which release it was, that would be helpful.
But where to put a version number? In the readme only? Any idea or thoughts on that @anarcat ?

I have done something for this in Wallabako. In the makefile, I have:

GFLAGS+=-ldflags="$(LDFLAGS) -X main.version=$(shell git describe --always --dirty)"

$(BINARY): *.go
	@echo building main program
	mkdir -p $$(dirname $(BINARY))
	go build $(GFLAGS) -o $@

and in the source:

var (
	// version is the program's version
	version = "undefined"
)

then i can just use that as a string... I wouldn't commit the version number in Git, that's just asking for trouble...

@Strubbl
Copy link
Owner

Strubbl commented Jun 20, 2017

I think this does not work for a library because it is compiled as depencency and the makefile does not get executed.

I am going to use this method for my wallabg-stats binary

@anarcat
Copy link
Contributor Author

anarcat commented Jun 27, 2017

true, not sure how that's done with libraries...

@anarcat
Copy link
Contributor Author

anarcat commented Feb 22, 2018

i think this can be closed - you tagged releases, thanks! :)

@anarcat anarcat closed this as completed Feb 22, 2018
@Strubbl
Copy link
Owner

Strubbl commented Feb 22, 2018

i do not like the "v" in the tag name anymore. In future tags are coming without that, but old tags are still valid, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants