From 626f75302de74b41e6e746a327ac6aa34b24a50d Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 15:26:35 +0200 Subject: [PATCH 01/11] close #132 --- .github/workflows/TagBot | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 .github/workflows/TagBot diff --git a/.github/workflows/TagBot b/.github/workflows/TagBot deleted file mode 100644 index f38961114..000000000 --- a/.github/workflows/TagBot +++ /dev/null @@ -1,20 +0,0 @@ -name: TagBot -on: - issue_comment: - types: - - created - workflow_dispatch: - inputs: - lookback: - default: 3 -permissions: - contents: write -jobs: - TagBot: - if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot' - runs-on: ubuntu-latest - steps: - - uses: JuliaRegistries/TagBot@v1 - with: - token: ${{ secrets.GITHUB_TOKEN }} - ssh: ${{ secrets.DOCUMENTER_KEY }} From b9e815503ca1788566c938e1d0873000f4450a6c Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 15:36:26 +0200 Subject: [PATCH 02/11] close #108 --- src/imply/empty.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/imply/empty.jl b/src/imply/empty.jl index 38ff2690c..65d0e3259 100644 --- a/src/imply/empty.jl +++ b/src/imply/empty.jl @@ -3,6 +3,7 @@ ############################################################################################ """ Empty placeholder for models that don't need an imply part. +(For example, models that only regularize parameters.) # Constructor From aecb1962f5b44223fae5b07fe1f8c467ac370c32 Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 15:39:20 +0200 Subject: [PATCH 03/11] close #130 --- src/StructuralEquationModels.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/StructuralEquationModels.jl b/src/StructuralEquationModels.jl index 17aa46d04..131ec206f 100644 --- a/src/StructuralEquationModels.jl +++ b/src/StructuralEquationModels.jl @@ -90,6 +90,7 @@ export AbstractSem, SemConstant, SemWLS, loss, SemOptimizer, SemOptimizerEmpty, SemOptimizerOptim, SemOptimizerNLopt, NLoptConstraint, + optimizer, n_iterations, convergence, SemObserved, SemObservedData, SemObservedCovariance, SemObservedMissing, observed, sem_fit, From 3616ad19feb21db8b1a463b513f782fabd7fe194 Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 15:47:05 +0200 Subject: [PATCH 04/11] close #139 --- .github/workflows/CI.yml | 2 +- .github/workflows/CI_extended.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 82570215d..9dd5ab6b7 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -15,7 +15,7 @@ jobs: fail-fast: true matrix: version: - - '1.7.3' + - '1' os: - ubuntu-latest arch: diff --git a/.github/workflows/CI_extended.yml b/.github/workflows/CI_extended.yml index f6857a517..b7b8c88e7 100644 --- a/.github/workflows/CI_extended.yml +++ b/.github/workflows/CI_extended.yml @@ -18,7 +18,7 @@ jobs: fail-fast: false matrix: version: - - '1.7.3' + - '1' os: - ubuntu-latest - macos-latest From 4477cbd1742aa3709d3ea9ff9f1f305806bf4ade Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 15:48:14 +0200 Subject: [PATCH 05/11] add forgotten file --- .github/workflows/TagBot.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/TagBot.yml diff --git a/.github/workflows/TagBot.yml b/.github/workflows/TagBot.yml new file mode 100644 index 000000000..f38961114 --- /dev/null +++ b/.github/workflows/TagBot.yml @@ -0,0 +1,20 @@ +name: TagBot +on: + issue_comment: + types: + - created + workflow_dispatch: + inputs: + lookback: + default: 3 +permissions: + contents: write +jobs: + TagBot: + if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot' + runs-on: ubuntu-latest + steps: + - uses: JuliaRegistries/TagBot@v1 + with: + token: ${{ secrets.GITHUB_TOKEN }} + ssh: ${{ secrets.DOCUMENTER_KEY }} From 33cd9f06f5f8fa042ca758691e652d423b1fe754 Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 16:42:59 +0200 Subject: [PATCH 06/11] update Test syntax for broken unit tests --- test/examples/political_democracy/constraints.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/examples/political_democracy/constraints.jl b/test/examples/political_democracy/constraints.jl index 5044f7540..a9bc7aa1a 100644 --- a/test/examples/political_democracy/constraints.jl +++ b/test/examples/political_democracy/constraints.jl @@ -61,6 +61,6 @@ end solution_constrained = sem_fit(model_ml_constrained) @test solution_constrained.solution[31]*solution_constrained.solution[30] >= 0.6 @test all(abs.(solution_constrained.solution) .< 10) - @test_skip solution_constrained.optimization_result.result[3] == :FTOL_REACHED + @test solution_constrained.optimization_result.result[3] == :FTOL_REACHED skip=true @test abs(solution_constrained.minimum - 21.21) < 0.01 end \ No newline at end of file From b6ebe48edb02be1fd593bc5cbb2dd5fd9c886ba0 Mon Sep 17 00:00:00 2001 From: maximilian Date: Fri, 9 Jun 2023 19:08:33 +0200 Subject: [PATCH 07/11] close #117 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index e2062f5a7..81a9edf06 100644 --- a/Project.toml +++ b/Project.toml @@ -24,7 +24,7 @@ StenoGraphs = "78862bba-adae-4a83-bb4d-33c106177f81" Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7" [compat] -julia = "1.7" +julia = "1.9" StenoGraphs = "0.2" DataFrames = "1" Distributions = "0.25" From 870f89dacf64035813e89a7b15297591643e5b22 Mon Sep 17 00:00:00 2001 From: maximilian Date: Sat, 10 Jun 2023 12:33:30 +0200 Subject: [PATCH 08/11] typo --- src/frontend/fit/standard_errors/hessian.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/fit/standard_errors/hessian.jl b/src/frontend/fit/standard_errors/hessian.jl index 1300d7cb4..e867c382a 100644 --- a/src/frontend/fit/standard_errors/hessian.jl +++ b/src/frontend/fit/standard_errors/hessian.jl @@ -26,7 +26,7 @@ function se_hessian(sem_fit::SemFit; hessian = :finitediff) elseif hessian == :expected throw(ArgumentError("standard errors based on the expected hessian are not implemented yet")) else - throw(ArgumentError("I dont know how to compute `$how` standard-errors")) + throw(ArgumentError("I dont know how to compute `$hessian` standard-errors")) end invH = c*inv(H) From 61a39b0d272c2836385e87dc2f516481ff366767 Mon Sep 17 00:00:00 2001 From: maximilian Date: Sat, 10 Jun 2023 13:29:34 +0200 Subject: [PATCH 09/11] add warning for WLS standard errors --- src/frontend/fit/standard_errors/hessian.jl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/frontend/fit/standard_errors/hessian.jl b/src/frontend/fit/standard_errors/hessian.jl index e867c382a..2afb08822 100644 --- a/src/frontend/fit/standard_errors/hessian.jl +++ b/src/frontend/fit/standard_errors/hessian.jl @@ -44,9 +44,14 @@ H_scaling(model::AbstractSemSingle) = model.optimizer, model.loss.functions...) -H_scaling(model, obs, imp, optimizer, lossfun::Union{SemML, SemWLS}) = +H_scaling(model, obs, imp, optimizer, lossfun::SemML) = 2/(n_obs(model)-1) +function H_scaling(model, obs, imp, optimizer, lossfun::SemWLS) + @warn "Standard errors for WLS are only correct if a GLS weight matrix (the default) is used." + return 2/(n_obs(model)-1) +end + H_scaling(model, obs, imp, optimizer, lossfun::SemFIML) = 2/n_obs(model) From b2c4b64b99856bba2fffca4d8b8a7415ea439150 Mon Sep 17 00:00:00 2001 From: maximilian Date: Tue, 13 Jun 2023 14:58:15 +0200 Subject: [PATCH 10/11] update package version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 81a9edf06..c8176911b 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "StructuralEquationModels" uuid = "383ca8c5-e4ff-4104-b0a9-f7b279deed53" authors = ["Maximilian Ernst", "Aaron Peikert"] -version = "0.1.0" +version = "0.2.0" [deps] DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" From 00b69f79a81dc0013766d55ce489dbb48db4f32a Mon Sep 17 00:00:00 2001 From: maximilian Date: Tue, 13 Jun 2023 15:01:00 +0200 Subject: [PATCH 11/11] update julia version for CI and docs --- .github/workflows/CI_ecosystem.yml | 5 +++-- .github/workflows/CI_extended.yml | 3 ++- .github/workflows/documentation.yml | 2 +- .github/workflows/preview-documentation.yml | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/CI_ecosystem.yml b/.github/workflows/CI_ecosystem.yml index a3fa15887..98a79eb0b 100644 --- a/.github/workflows/CI_ecosystem.yml +++ b/.github/workflows/CI_ecosystem.yml @@ -18,7 +18,8 @@ jobs: fail-fast: false matrix: version: - - '1.7.3' + - '1' + - '1.9' os: - ubuntu-latest - macos-latest @@ -42,4 +43,4 @@ jobs: - uses: julia-actions/julia-processcoverage@v1 - uses: codecov/codecov-action@v2 with: - file: lcov.info \ No newline at end of file + file: lcov.info diff --git a/.github/workflows/CI_extended.yml b/.github/workflows/CI_extended.yml index b7b8c88e7..4cc24d90d 100644 --- a/.github/workflows/CI_extended.yml +++ b/.github/workflows/CI_extended.yml @@ -19,6 +19,7 @@ jobs: matrix: version: - '1' + - '1.9' os: - ubuntu-latest - macos-latest @@ -42,4 +43,4 @@ jobs: - uses: julia-actions/julia-processcoverage@v1 - uses: codecov/codecov-action@v2 with: - file: lcov.info \ No newline at end of file + file: lcov.info diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml index beac68371..e7dacab73 100644 --- a/.github/workflows/documentation.yml +++ b/.github/workflows/documentation.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/checkout@v2 - uses: julia-actions/setup-julia@latest with: - version: '1.7.2' + version: '1' - name: Install dependencies run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()' - name: Build and deploy diff --git a/.github/workflows/preview-documentation.yml b/.github/workflows/preview-documentation.yml index 9bc3297fd..29373527b 100644 --- a/.github/workflows/preview-documentation.yml +++ b/.github/workflows/preview-documentation.yml @@ -16,7 +16,7 @@ jobs: - uses: actions/checkout@v2 - uses: julia-actions/setup-julia@latest with: - version: '1.6' + version: '1' - name: Install dependencies run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()' - name: Build and deploy @@ -36,4 +36,4 @@ jobs: owner: context.repo.owner, repo: context.repo.repo, body: 'Docs can be previewed here: ${{ env.GHP_URL }}previews/PR${{ env.PR_NUMBER }}' - }) \ No newline at end of file + })