diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index f24320fa4..3656c71cc 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -6,6 +6,9 @@ on: jobs: code-style: runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write steps: - uses: julia-actions/julia-format@v2 with: diff --git a/src/loss/ML/ML.jl b/src/loss/ML/ML.jl index e6616258d..15a7d3fb0 100644 --- a/src/loss/ML/ML.jl +++ b/src/loss/ML/ML.jl @@ -459,18 +459,12 @@ end # objective, gradient ---------------------------------------------------------------------- function objective!( - semml::SemML, - par, - model::AbstractSemSingle, - has_meanstructure::Val{T}, - imp::RAM, -) where {T} - let Σ = Σ(imply(model)), - Σₒ = obs_cov(observed(model)), - Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml), - Σ⁻¹ = Σ⁻¹(semml), - μ = μ(imply(model)), - μₒ = obs_mean(observed(model)) + semml::SemML, + par, + model::AbstractSemSingle, + has_meanstructure::Val{T}, imp::RAM) where T + let Σ = Σ(imply(model)), Σₒ = obs_cov(observed(model)), Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml), + Σ⁻¹ = Σ⁻¹(semml), μ = μ(imply(model)), μₒ = obs_mean(observed(model)) copyto!(Σ⁻¹, Σ) Σ_chol = cholesky!(Symmetric(Σ⁻¹); check = false)