Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cached #127

Merged
merged 1 commit into from
Mar 17, 2023
Merged

remove cached #127

merged 1 commit into from
Mar 17, 2023

Conversation

STorm175
Copy link
Collaborator

COOL NEW PAGE !!!!

Page name: <Name>Page

Contributors

Describe your changes

Have we discussed about this before ? (Please link the discussion link below)

Added page requirements as following:

  • Page.xaml
    • Change the x:Class to project namespace standard (ex: x:Class="MAUIsland.LabelPage")?
    • Include xmlns:app="clr-namespace:MAUIsland"?
    • Change ContentPage to app:BasePage?
    • Hook the x:DataType to the ViewModel?
    • Provide Padding="10" to app:BasePage?
    • Provide ControlInfo to app:BasePage.Resources?
    • Provide PropertiesListHeader to app:BasePage.Resources?
    • Provide PropertiesListFooter to app:BasePage.Resources?
    • Provide PropertyItemsSource to app:BasePage.Resources?
    • Provide a brief Control Info UI ?
         <Frame Style="{x:StaticResource DocumentContentFrameStyle}">
                  <Label Text="{x:StaticResource ControlInfo}" />
         </Frame>
      • Provide Properties List UI ?
         <Frame Style="{x:StaticResource DocumentContentFrameStyle}">
                  <CollectionView
                      Footer="{x:StaticResource PropertiesListFooter}"
                      Header="{x:StaticResource PropertiesListHeader}"
                      ItemsSource="{x:StaticResource PropertyItemsSource}"
                      Style="{x:StaticResource PropertiesListStyle}" />
         </Frame>
  • Page.xaml.cs
    • Did you change the namespace to project namespace standard namespace MAUIsland?
    • Did you remove inheritance ContentPage?
    • Did you organize everything inside region?
    • Did you change <Page>ViewModel into the constructor parmeter?
    • Did you hook the page binding context to the page view model - BindingContext = vm; ?
  • PageViewModel.cs
    • Did you inherit the NavigationAwareBaseViewModel?
    • Did you organize everything inside region?
    • Did you modify the constructor like the example we provide?
      #region [CTor]
      public LabelPageViewModel(IAppNavigator appNavigator)
                                      : base(appNavigator)
      {
      
      }
      #endregion

Register page route requirements as following:

  • Did you create now route constant ?
  • Did you register page route in AppShell.xaml.cs ?
  • If the page is one of applciation root route did you register it to AppShell.xaml ?

Register page services:

  • Did you register the page with the view model in RegisterPages ?
  • Did you register all the created services RegisterServices ?

@STorm175 STorm175 requested a review from Strypper March 17, 2023 03:27
@Strypper Strypper merged commit 814fad8 into main Mar 17, 2023
@Strypper Strypper deleted the bug/126_git_ignore branch March 17, 2023 03:28
@Strypper Strypper linked an issue Mar 17, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: appsettings.Development.json doesn't ignore on git
2 participants