New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinSdkVersion 16 #1

Closed
jjvargas opened this Issue Feb 10, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@jjvargas

jjvargas commented Feb 10, 2015

Would it be possible in the future to lower the minSdkversion to 14 at least?

@Stuart-campbell

This comment has been minimized.

Show comment
Hide comment
@Stuart-campbell

Stuart-campbell Feb 10, 2015

Owner

I shall look at that tomorrow, but should not be a problem.

Owner

Stuart-campbell commented Feb 10, 2015

I shall look at that tomorrow, but should not be a problem.

@Stuart-campbell

This comment has been minimized.

Show comment
Hide comment
@Stuart-campbell

Stuart-campbell Feb 10, 2015

Owner

The jar should already work on 14 even though the project is set to a min of 19.

Owner

Stuart-campbell commented Feb 10, 2015

The jar should already work on 14 even though the project is set to a min of 19.

@Stuart-campbell Stuart-campbell self-assigned this Feb 11, 2015

@jjvargas jjvargas closed this Feb 11, 2015

@planiel

This comment has been minimized.

Show comment
Hide comment
@planiel

planiel Mar 30, 2015

Except that it doesn't. The problem is android 4.0 uses sqllite version 3.7.4, which doesn't support mass-insert.

planiel commented Mar 30, 2015

Except that it doesn't. The problem is android 4.0 uses sqllite version 3.7.4, which doesn't support mass-insert.

@Stuart-campbell

This comment has been minimized.

Show comment
Hide comment
@Stuart-campbell

Stuart-campbell Mar 30, 2015

Owner

Didn't notice that.

Looks like updating to be backwards compatible is possible though, from this post.

http://stackoverflow.com/questions/1609637/is-it-possible-to-insert-multiple-rows-at-a-time-in-an-sqlite-database

I will have to test if its worth doing. Would rather support the future because the speed boost is massive. Far more worth while that the libraries that cut out annotations.

As of now looks like min SDK is 16 (4.1)

Owner

Stuart-campbell commented Mar 30, 2015

Didn't notice that.

Looks like updating to be backwards compatible is possible though, from this post.

http://stackoverflow.com/questions/1609637/is-it-possible-to-insert-multiple-rows-at-a-time-in-an-sqlite-database

I will have to test if its worth doing. Would rather support the future because the speed boost is massive. Far more worth while that the libraries that cut out annotations.

As of now looks like min SDK is 16 (4.1)

@Stuart-campbell Stuart-campbell changed the title from MinSdkVersion 19 to MinSdkVersion 16 Mar 30, 2015

Stuart-campbell added a commit that referenced this issue Apr 3, 2015

Startup crash #17 Added null check to logger. MinSdkVersion 16 #1 add…
…ed single insert for android version before 16
@Stuart-campbell

This comment has been minimized.

Show comment
Hide comment
@Stuart-campbell

Stuart-campbell Apr 3, 2015

Owner

As of version 1.1.2 Rush will use bulk inserts above android 4.1 or single inserts below. As far as I can tell there are now no sql calls not supported from day 1 of android and the no api calls from after Android api 4.

I have only tested back to 14 though.

Owner

Stuart-campbell commented Apr 3, 2015

As of version 1.1.2 Rush will use bulk inserts above android 4.1 or single inserts below. As far as I can tell there are now no sql calls not supported from day 1 of android and the no api calls from after Android api 4.

I have only tested back to 14 though.

@planiel

This comment has been minimized.

Show comment
Hide comment
@planiel

planiel Apr 3, 2015

Awesome! thanks.

planiel commented Apr 3, 2015

Awesome! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment