Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/section lambda render #55

Merged
merged 3 commits into from Jun 2, 2019

Conversation

Projects
None yet
1 participant
@Romanx
Copy link
Contributor

commented Jun 2, 2019

Related to #46

@Romanx Romanx self-assigned this Jun 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 2, 2019

Codecov Report

Merging #55 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   97.28%   97.32%   +0.04%     
==========================================
  Files          73       73              
  Lines        1986     2019      +33     
==========================================
+ Hits         1932     1965      +33     
  Misses         54       54
Impacted Files Coverage Δ
...ingRenderer/TokenRenderers/SectionTokenRenderer.cs 100% <100%> (ø) ⬆️
...n/Renderers/TokenRenderers/SectionTokenRenderer.cs 97.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8654bf0...f7437cf. Read the comment docs.

Romanx added some commits Jun 2, 2019

Add lambda overload for rendering in context
This allocates a new string writer for this which isn't super efficent
but this isn't likely to be a common case

@Romanx Romanx force-pushed the feature/section-lambda-render branch from 9fcabf7 to f7437cf Jun 2, 2019

@Romanx Romanx merged commit b98e6f0 into master Jun 2, 2019

6 checks passed

codecov/patch 100% of diff hit (target 97.28%)
Details
codecov/project 97.32% (+0.04%) compared to 8654bf0
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Romanx Romanx deleted the feature/section-lambda-render branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.