New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown in the shell are not reported any more (0.9.0-RC4) #1035

Closed
adampridmore opened this Issue Feb 23, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@adampridmore
Copy link

adampridmore commented Feb 23, 2016

As far as I can tell as of version 0.9.x runtime exceptions in the shell are not reported in the output pane.

Example:

throw "Error";

Output in Robomongo 0.8.5 (Windows 10)

uncaught exception: Error

Output in Robomongo 0.9.0-RC4 (Windows 10)

Nothing!

Notes

This is a slightly more realistic and less contrived example of a runtime exception, which is not reported in 0.9.0-RC4

var text = null;
text.toString();
@mayask

This comment has been minimized.

Copy link
Collaborator

mayask commented Feb 24, 2016

Thanks Adam for reporting this issue.
We'll address that in the upcoming releases.
Max

@schetnikovich schetnikovich added this to the Robomongo 0.9.0 RC7 milestone Feb 29, 2016

@schetnikovich

This comment has been minimized.

Copy link
Contributor

schetnikovich commented Feb 29, 2016

@adampridmore This issue is fixed and all errors are now reported to the output pane. This fix will be shipped with upcoming RC7 release. Thank you for reporting!

@juliashibalko

This comment has been minimized.

Copy link
Collaborator

juliashibalko commented Mar 2, 2016

@schetnikovich please, take a look at Windows version. Logs are shown correctly, but errors don't occur in the output http://prntscr.com/aa98rv (0.9RC7 under Win 10, 8.1, 7 x64)

@juliashibalko juliashibalko reopened this Mar 2, 2016

@juliashibalko

This comment has been minimized.

Copy link
Collaborator

juliashibalko commented Mar 2, 2016

Under Windows
>var testVar = null; testVar.toString();
mongo shell has next error in output: 2016-03-02T17:46:02.599+0300 E QUERY [thread1] TypeError: testVar is null : @(shell):1:25
robomongo shell output: TypeError: testVar has no properties (shell):1
Also may we add more details to show in the output?

@schetnikovich

This comment has been minimized.

Copy link
Contributor

schetnikovich commented Mar 3, 2016

@juliashibalko Tested just now and it works for me. Seems that you received build without changes that were made to robomongo-shell. We will rebuild and ship updated build to you soon.

As for errors, here is an output that I receive on both Windows and Mac:

TypeError: testVar is null :
@(shell):1:1

And it is the same as for MongoDB shell (except 2016-03-02T17:46:02.599+0300 E QUERY [thread1] part)

@schetnikovich

This comment has been minimized.

Copy link
Contributor

schetnikovich commented Mar 4, 2016

@juliashibalko Does the latest build work for you on Windows?

@anorsich

This comment has been minimized.

Copy link
Contributor

anorsich commented Mar 4, 2016

@schetnikovich I just checked the latest build on windows and it works as expected. I think we are ready to go.

@juliashibalko

This comment has been minimized.

Copy link
Collaborator

juliashibalko commented Mar 4, 2016

@schetnikovich works as expected under supported versions of Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment