Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a document that has been requested using a projection, the resulting document is clobbered #881

Closed
fresheneesz opened this issue May 28, 2015 · 10 comments

Comments

6 participants
@fresheneesz
Copy link

commented May 28, 2015

If I search for documents using a projection that only selects for 1 property, then I click on a field in the table and choose "Edit Document", a window will pop up with the document as fetched from the database (with only the field selected in the projection). If I then modify the value of that field, the whole document is clobbered except for the field that appeared in the "Edit Document" window.

This is not expected nor desired. If I edit just one value of one field in that "Edit Document" window - I expect that's the only value that will be changed. What robomongo should do here is some kind of diff to figure out what changed, and make only that change.

@anorsich anorsich added the bug label Feb 2, 2016

@anorsich

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2016

@schetnikovich Sounds like a crytical issue. We need to fetch full document when editing.

@revolter

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2016

Yep, it's a highly critical issue that I noticed the hard way! Is there any possibility for this to be fixed in the next release? Also, is there a way I can help with this?

@simsekgokhan simsekgokhan added the major label Oct 31, 2016

@simsekgokhan

This comment has been minimized.

Copy link
Collaborator

commented Oct 31, 2016

Hi @revolter , I also agree that this is a very important problem. Currently, we are focused on delivering some critical features Replica Sets and Export/Import. Any help/contribution is very welcome.

@revolter

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2016

Could you point me out to a file/function as I'm obviously not accustomed with the code base?

@simsekgokhan

This comment has been minimized.

Copy link
Collaborator

commented Oct 31, 2016

Sure, it should be in /src/robomongo/core/domain/Notifier.cpp and DocumentTextEditor class is created with "Edit Document". But obviously this is just the start of interface, the problem should probably be fixed in deeper calls which needs the real investigation/work.

Please also see how to build guide and our coding guidelines here:
https://github.com/paralect/robomongo/wiki

Please let me if you need any help.

@prathamsaroha

This comment has been minimized.

Copy link

commented Oct 5, 2017

I also found this the hard way. This is a critical issue.

@fresheneesz

This comment has been minimized.

Copy link
Author

commented Oct 5, 2017

2.5 years and this is still an issue? Come on guys, this is embarrassingly, and should be easy to fix. Just keep track of the properties in the projection and only update those. Why are contributors dragging their feet on this?

@revolter

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2017

I think that the best temporary solution is to disable the save button, this way, the most important thing - not lose important data - is prevented, until the save works in the correct way.

Not being able to edit a filtered result is not uncommon, many SQL clients don't allow this at all because of the complexity (e.g. using joins) of the update handling, so I don't believe it would come as a very big surprise, opposed to the surprise of losing potentially production data.

@simsekgokhan simsekgokhan added this to Ready-For-Testing in Robo 3T 1.2 Dec 20, 2017

@simsekgokhan simsekgokhan self-assigned this Dec 20, 2017

@acawood777

This comment has been minimized.

Copy link

commented Aug 31, 2018

Also found this the hard way... was still running 1.1
Can confirm that 1.2 only allows View - no Edit option.

@simsekgokhan

This comment has been minimized.

Copy link
Collaborator

commented Nov 16, 2018

@ALL, we are very sorry for the long delay. The critical part of the issue is addressed in version 1.2. See more: https://blog.robomongo.org/robo-3t-1-2/#a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.