Add support to return the html content #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrom
requested changes
Feb 21, 2021
There was a problem hiding this comment.
Looks like a good change @paresharma 馃憤
I've got one suggestion about the processor specs if you can take a look
spec/grover/processor_spec.rb
Outdated
| HTML | ||
| end | ||
|
|
||
| it { expect(convert.gsub(/[[:space:]]+/, '')).to eq url_or_html.gsub(/[[:space:]]+/, '') } |
There was a problem hiding this comment.
Two things here.. I'd suggest using Grover::Utils.squish rather than removing all spaces. Would still give a consistent result whilst being true to the rendered output. Also, it feels like this would be a good opportunity to test that the rendered HTML is returned. ie something like:
context 'when rendering HTML' do
let(:method) { :content }
let(:url_or_html) do
<<-HTML
<html>
<head></head>
<body>
<h1>Hey there</h1>
<h2>Konnichiwa</h2>
<script>document.querySelector('h1').remove();</script>
</body>
</html>
HTML
end
it 'returns the rendered HTML' do
expect(Grover::Utils.squish(convert)).to eq Grover::Utils.squish(<<~HTML)
<html><head></head>
<body>
<h2>Konnichiwa</h2>
<script>document.querySelector('h1').remove();</script>
</body></html>
HTML
end
end
Ie not just what you gave it, but rather the result of it being rendered.
There was a problem hiding this comment.
Good catch and point, thanks. Updated 馃檶
|
Great thanks. I would appreciate if you could release these changes 馃檶 |
|
Released in 0.14.2 |
|
Thank you 馃檶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to retrieve the HTML content. I just find it particularly helpful in debugging PDFs.
Let me know what you think about this 馃檶
FYI: puppeteer/puppeteer#419