Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in meta-option parsing #14

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
2 participants
@abrom
Copy link
Contributor

commented May 23, 2019

If HTML content passed through contains any line starting with http the option parser was incorrectly identifying the source as a URL and thus not including those options

Update puppeteer development dependency to 1.16.0

Fix bug in meta-option parsing if content contained any line starting…
… with `http`

Update puppeteer development dependency to 1.16.0

@abrom abrom added the bug label May 23, 2019

@abrom abrom merged commit 552c572 into master May 23, 2019

5 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 98% (1.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abrom abrom deleted the fix-meta-data-parse-check branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.